Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 60573004: Disable SyntheticGestureControllerNewTest.SingleGesture on windows due (Closed)

Created:
7 years, 1 month ago by dgrogan
Modified:
7 years, 1 month ago
Reviewers:
Dominik Grewe
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Disable SyntheticGestureControllerNewTest.SingleGesture on windows due to win_rel flakiness. BUG=314272 TBR=dominikg@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233064

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M content/browser/renderer_host/input/synthetic_gesture_controller_new_unittest.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dgrogan
7 years, 1 month ago (2013-11-05 20:00:49 UTC) #1
dgrogan
Committed patchset #1 manually as r233064 (presubmit successful).
7 years, 1 month ago (2013-11-05 20:06:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/60573004/1
7 years, 1 month ago (2013-11-05 20:07:01 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 20:07:03 UTC) #4
Message was sent while issue was closed.
Failed to apply patch for
content/browser/renderer_host/input/synthetic_gesture_controller_new_unittest.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
content/browser/renderer_host/input/synthetic_gesture_controller_new_unittest.cc
  Hunk #1 FAILED at 186.
  1 out of 1 hunk FAILED -- saving rejects to file
content/browser/renderer_host/input/synthetic_gesture_controller_new_unittest.cc.rej

Patch:      
content/browser/renderer_host/input/synthetic_gesture_controller_new_unittest.cc
Index:
content/browser/renderer_host/input/synthetic_gesture_controller_new_unittest.cc
diff --git
a/content/browser/renderer_host/input/synthetic_gesture_controller_new_unittest.cc
b/content/browser/renderer_host/input/synthetic_gesture_controller_new_unittest.cc
index
69f52025f44e519df0f388ef2f5051fe921be991..5d00354035c263f4885c0f36e468ca416aba6a08
100644
---
a/content/browser/renderer_host/input/synthetic_gesture_controller_new_unittest.cc
+++
b/content/browser/renderer_host/input/synthetic_gesture_controller_new_unittest.cc
@@ -186,7 +186,13 @@ class SyntheticGestureControllerNewTest : public
testing::Test {
   const MockSyntheticGestureTarget* target_ptr_;
 };
 
-TEST_F(SyntheticGestureControllerNewTest, SingleGesture) {
+// http://crbug.com/314272
+#if defined(OS_WIN)
+#define MAYBE_SingleGesture DISABLED_SingleGesture
+#else
+#define MAYBE_SingleGesture SingleGesture
+#endif
+TEST_F(SyntheticGestureControllerNewTest, MAYBE_SingleGesture) {
   bool finished;
   scoped_ptr<MockSyntheticGesture> gesture(
       new MockSyntheticGesture(&finished, 3));

Powered by Google App Engine
This is Rietveld 408576698