Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1695)

Unified Diff: content/renderer/pepper/v8_var_converter.cc

Issue 605593002: PPAPI: Support sending browser-hosted resources synchronously Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix content_browsertests Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/pepper/v8_var_converter.cc
diff --git a/content/renderer/pepper/v8_var_converter.cc b/content/renderer/pepper/v8_var_converter.cc
index 42d744d28729db928fddb3e532b4b59e8f68c9a6..2c4945ce4498be207c4eac29d2c78a981cdfcb40 100644
--- a/content/renderer/pepper/v8_var_converter.cc
+++ b/content/renderer/pepper/v8_var_converter.cc
@@ -450,10 +450,13 @@ bool V8VarConverter::FromV8ValueSync(
v8::Handle<v8::Context> context,
ppapi::ScopedPPVar* result_var) {
bool success = FromV8ValueInternal(val, context, result_var);
- if (!success || resource_converter_->NeedsFlush()) {
+ if (!success) {
resource_converter_->Reset();
return false;
}
+ if (resource_converter_->NeedsFlush()) {
+ resource_converter_->FlushSync();
+ }
return true;
}
« no previous file with comments | « content/renderer/pepper/url_response_info_util.cc ('k') | content/renderer/pepper/v8_var_converter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698