Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 605563003: QUIC - Code to persist if we had talked QUIC to a server and if so what (Closed)

Created:
6 years, 2 months ago by ramant (doing other things)
Modified:
6 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

QUIC - Code to persist if we had talked QUIC to a server and if so what is the address. This code is not hooked up into QUIC code yet. Will submit that in the next CL. R=rch@chromium.org Committed: https://crrev.com/1c863aa414026f2ece4ce5b930bcbce1cd07d6f0 Cr-Commit-Position: refs/heads/master@{#296749}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -12 lines) Patch
M net/http/http_server_properties.h View 2 chunks +25 lines, -0 lines 0 comments Download
M net/http/http_server_properties_impl.h View 3 chunks +14 lines, -0 lines 0 comments Download
M net/http/http_server_properties_impl.cc View 3 chunks +33 lines, -0 lines 0 comments Download
M net/http/http_server_properties_impl_unittest.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M net/http/http_server_properties_manager.h View 3 chunks +12 lines, -0 lines 0 comments Download
M net/http/http_server_properties_manager.cc View 12 chunks +103 lines, -9 lines 0 comments Download
M net/http/http_server_properties_manager_unittest.cc View 8 chunks +57 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
ramant (doing other things)
6 years, 2 months ago (2014-09-24 23:52:29 UTC) #1
Ryan Hamilton
I'm not sure I understand. I thought we wanted a single global for this? Or ...
6 years, 2 months ago (2014-09-25 00:47:30 UTC) #2
ramant (doing other things)
On 2014/09/25 00:47:30, Ryan Hamilton wrote: > I'm not sure I understand. I thought we ...
6 years, 2 months ago (2014-09-25 02:52:14 UTC) #3
Ryan Hamilton
On 2014/09/25 02:52:14, ramant wrote: > On 2014/09/25 00:47:30, Ryan Hamilton wrote: > > I'm ...
6 years, 2 months ago (2014-09-25 02:59:16 UTC) #4
Ryan Hamilton
Ok, I see what you're doing. This seems like a fine way to get this ...
6 years, 2 months ago (2014-09-25 03:02:57 UTC) #5
ramant (doing other things)
On 2014/09/25 02:59:16, Ryan Hamilton wrote: > On 2014/09/25 02:52:14, ramant wrote: > > On ...
6 years, 2 months ago (2014-09-25 04:14:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/605563003/1
6 years, 2 months ago (2014-09-25 18:29:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 30107ac5fd05e51f6ea4c7e27c6d2520928baeef
6 years, 2 months ago (2014-09-25 18:39:52 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 18:42:19 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c863aa414026f2ece4ce5b930bcbce1cd07d6f0
Cr-Commit-Position: refs/heads/master@{#296749}

Powered by Google App Engine
This is Rietveld 408576698