Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 605563002: Remove implicit HANDLE conversions from printing. (Closed)

Created:
6 years, 3 months ago by rvargas (doing something else)
Modified:
6 years, 2 months ago
Reviewers:
Scott Byer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit HANDLE conversions from printing. BUG=416722 R=scottbyer@chromium.org Committed: https://crrev.com/9b7c6b0fc723a3c079c290dcd836dee9013d5084 Cr-Commit-Position: refs/heads/master@{#296759}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
M printing/backend/print_backend_win.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M printing/backend/win_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/emf_win.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M printing/image_win.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M printing/printing_context_win.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M printing/printing_context_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
rvargas (doing something else)
6 years, 3 months ago (2014-09-24 22:53:22 UTC) #1
Scott Byer
lgtm
6 years, 2 months ago (2014-09-25 18:10:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/605563002/1
6 years, 2 months ago (2014-09-25 19:17:47 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 375a30b3f6c2b7316caa24bebb20d8c04e236b70
6 years, 2 months ago (2014-09-25 19:22:54 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 19:23:47 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b7c6b0fc723a3c079c290dcd836dee9013d5084
Cr-Commit-Position: refs/heads/master@{#296759}

Powered by Google App Engine
This is Rietveld 408576698