Make subtype test stubs isolate-specific.

runtime/vm/assembler_arm.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_ARM)
 
 #include "vm/assembler.h"
 #include "vm/cpu.h"
 #include "vm/longjump.h"
@@ skipping 1710 matching lines @@
 
 void Assembler::LoadClassId(Register result, Register object, Condition cond) {
   ASSERT(RawObject::kClassIdTagPos == 16);
   ASSERT(RawObject::kClassIdTagSize == 16);
   const intptr_t class_id_offset = Object::tags_offset() +
       RawObject::kClassIdTagPos / kBitsPerByte;
   ldrh(result, FieldAddress(object, class_id_offset), cond);
 }
 
 
-void Assembler::LoadClassById(Register result, Register class_id) {
+void Assembler::LoadClassById(Register result,
+                              Register class_id,
+                              Isolate* isolate) {

[Vyacheslav Egorov (Google), 2014/09/26 13:09:43]

Can we make isolate member of the assembler?

[Florian Schneider, 2014/09/26 14:05:02]

Yes, this would be a bigger change (since we should also replace all uses of
Isolate::Current in the assembler then. For now I'll use Isolate::Current
instead.

   ASSERT(result != class_id);
-  ldr(result, FieldAddress(CTX, Context::isolate_offset()));
-  const intptr_t table_offset_in_isolate =
-      Isolate::class_table_offset() + ClassTable::table_offset();
-  LoadFromOffset(kWord, result, result, table_offset_in_isolate);
+  LoadImmediate(result, isolate->ClassTableAddress());
+  LoadFromOffset(kWord, result, result, 0);
   ldr(result, Address(result, class_id, LSL, 2));
 }
 
 
-void Assembler::LoadClass(Register result, Register object, Register scratch) {
+void Assembler::LoadClass(Register result,
+                          Register object,
+                          Register scratch,
+                          Isolate* isolate) {
   ASSERT(scratch != result);
   LoadClassId(scratch, object);
-
-  ldr(result, FieldAddress(CTX, Context::isolate_offset()));
-  const intptr_t table_offset_in_isolate =
-      Isolate::class_table_offset() + ClassTable::table_offset();
-  LoadFromOffset(kWord, result, result, table_offset_in_isolate);
-  ldr(result, Address(result, scratch, LSL, 2));
+  LoadClassById(result, scratch, isolate);
 }
 
 
 void Assembler::CompareClassId(Register object,
                                intptr_t class_id,
                                Register scratch) {
   LoadClassId(scratch, object);
   CompareImmediate(scratch, class_id);
 }
 
@@ skipping 1661 matching lines @@
 
 
 const char* Assembler::FpuRegisterName(FpuRegister reg) {
   ASSERT((0 <= reg) && (reg < kNumberOfFpuRegisters));
   return fpu_reg_names[reg];
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_ARM