Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 60553003: Revert 233039 "Blink roll 161254:161319" (Closed)

Created:
7 years, 1 month ago by dgrogan
Modified:
7 years, 1 month ago
Reviewers:
Nico, eseidel
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 233039 "Blink roll 161254:161319" Caused compile failures http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29%2832%29/builds/13904/steps/compile/logs/stdio FAILED: g++ -MMD -MF obj/third_party/WebKit/Source/wtf/wtf.PartitionAlloc.o.d -DANGLE_DX11 -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DCOMPONENT_BUILD -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_NSS=1 -DUSE_X11=1 -DENABLE_ONE_CLICK_SIGNIN -DGTK_DISABLE_SINGLE_INCLUDES=1 -DUSE_XI2_MT=2 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DWTF_IMPLEMENTATION=1 -DENABLE_CUSTOM_SCHEME_HANDLER=0 -DENABLE_ENCRYPTED_MEDIA_V2=1 -DENABLE_SVG_FONTS=1 -DENABLE_GDI_FONTS_ON_WINDOWS=0 -DENABLE_HARFBUZZ_ON_WINDOWS=0 -DENABLE_TOUCH_ICON_LOADING=0 -DWTF_USE_CONCATENATED_IMPULSE_RESPONSES=1 -DENABLE_CALENDAR_PICKER=1 -DENABLE_INPUT_SPEECH=1 -DENABLE_INPUT_MULTIPLE_FIELDS_UI=1 -DENABLE_LEGACY_NOTIFICATIONS=1 -DENABLE_MEDIA_CAPTURE=0 -DENABLE_NAVIGATOR_CONTENT_UTILS=1 -DENABLE_ORIENTATION_EVENTS=0 -DENABLE_WEB_AUDIO=1 -DWTF_USE_WEBAUDIO_FFMPEG=1 -DENABLE_OPENTYPE_VERTICAL=1 -DWTF_USE_DEFAULT_RENDER_THEME=1 -DU_USING_ICU_NAMESPACE=0 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -I../../third_party/WebKit/Source -I../../third_party/WebKit -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I/usr/include32 -fstack-protector --param=ssp-buffer-size=4 -Werror -pthread -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -m32 -mmmx -march=pentium4 -msse2 -mfpmath=sse -O0 -g -Wno-c++0x-compat -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -Wno-c++0x-compat -c ../../third_party/WebKit/Source/wtf/PartitionAlloc.cpp -o obj/third_party/WebKit/Source/wtf/wtf.PartitionAlloc.o ../../third_party/WebKit/Source/wtf/PartitionAlloc.cpp: In function 'void WTF::partitionDumpStats(const WTF::PartitionRoot&)': ../../third_party/WebKit/Source/wtf/PartitionAlloc.cpp:534:328:error: format '%ld' expects argument of type 'long int', but argument 2 has type 'size_t {aka unsigned int}' [-Werror=format] > Blink roll 161254:161319 > > http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=161255:161319&mode=html > TBR= > BUG= > > Review URL: https://codereview.chromium.org/59393004 TBR=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233042

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M trunk/src/DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
dgrogan
7 years, 1 month ago (2013-11-05 19:00:54 UTC) #1
dgrogan
Committed patchset #1 manually as r233042.
7 years, 1 month ago (2013-11-05 19:01:04 UTC) #2
Nico
7 years, 1 month ago (2013-11-05 19:20:53 UTC) #3
Message was sent while issue was closed.
These errors are probably fixed by
https://src.chromium.org/viewvc/blink?view=revision&revision=161356

We think this is a 32bit vs 64bit issue. The cq builds 64 bit, main waterfall
both 64 and 32 bit. Rolling to r161356 or newer should hopefully fix this (and
should also make this kind of error visible on the blink waterfall since the
android bots build 32bit and now build with warnings)

Powered by Google App Engine
This is Rietveld 408576698