Issue 605503002: Shrink the user manager to 800x600.

Issue 605503002: Shrink the user manager to 800x600. (Closed)

Created:
6 years, 3 months ago by Mike Lerman

Modified:
6 years, 2 months ago

Reviewers:
Peter Kasting, Alexei Svitkine (slow)

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Shrink the user manager to 800x600. BUG=405524 Committed: https://crrev.com/cf2a33b67c91057e09772eb59ade5b7ae491f26a Cr-Commit-Position: refs/heads/master@{#296717}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -16 lines)			Patch
M	chrome/browser/ui/cocoa/profiles/user_manager_mac.mm	View	3 chunks	+6 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/user_manager.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/profiles/user_manager_view.cc	View	3 chunks	+3 lines, -6 lines	0 comments	Download

Total messages: 10 (3 generated)

Mike Lerman

Hi Peter, Can I get a review of this ui code? Thanks! Mike

6 years, 3 months ago (2014-09-24 20:22:55 UTC) #2

Peter Kasting

LGTM, but it'd still be nice to try and compute this dynamically instead, even if ...

6 years, 3 months ago (2014-09-24 21:25:45 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/605503002/1

6 years, 2 months ago (2014-09-25 15:59:27 UTC) #8

commit-bot: I haz the power

Committed patchset #1 (id:1) as 252cc628343c32699718d446f0d644b3f4d3d9b8

6 years, 2 months ago (2014-09-25 16:13:47 UTC) #9

commit-bot: I haz the power

6 years, 2 months ago (2014-09-25 16:14:23 UTC) #10

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/cf2a33b67c91057e09772eb59ade5b7ae491f26a
Cr-Commit-Position: refs/heads/master@{#296717}