Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: runtime/vm/bootstrap.cc

Issue 605493002: Do not eagerly compile the function implementation class in case of an error. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/bootstrap.cc
===================================================================
--- runtime/vm/bootstrap.cc (revision 40638)
+++ runtime/vm/bootstrap.cc (working copy)
@@ -315,17 +315,17 @@
if (error.IsNull()) {
SetupNativeResolver();
ClassFinalizer::ProcessPendingClasses();
+
+ Class& cls = Class::Handle(isolate);
+ // Eagerly compile the function implementation class as it is the super
+ // class of signature classes. This allows us to just finalize signature
+ // classes without going through the hoops of trying to compile them.
+ const Type& type =
+ Type::Handle(isolate, isolate->object_store()->function_impl_type());
+ cls = type.type_class();
+ Compiler::CompileClass(cls);
}
- Class& cls = Class::Handle(isolate);
- // Eagerly compile the function implementation class as it is the super
- // class of signature classes. This allows us to just finalize signature
- // classes without going through the hoops of trying to compile them.
- const Type& type =
- Type::Handle(isolate, isolate->object_store()->function_impl_type());
- cls = type.type_class();
- Compiler::CompileClass(cls);
-
// Restore the library tag handler for the isolate.
isolate->set_library_tag_handler(saved_tag_handler);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698