Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issue 605473002: Domain Reliablity: Add "domain" field to reports. (Closed)

Created:
6 years, 2 months ago by Deprecated (see juliatuttle)
Modified:
6 years, 2 months ago
Reviewers:
davidben
CC:
chromium-reviews, pavlos
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Domain Reliablity: Add "domain" field to reports. Add a "domain" field that returns the hostname of the original request. This lets sites with wildcard contexts tell which subdomain triggered the beacons they receive. BUG= Committed: https://crrev.com/1e1d803bda102882f6afebab7d6bce04d262c8d7 Cr-Commit-Position: refs/heads/master@{#296947}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M components/domain_reliability/beacon.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/domain_reliability/beacon.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/domain_reliability/context_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/domain_reliability/monitor.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Deprecated (see juliatuttle)
PTAL, davidben. FYI, pavlos.
6 years, 2 months ago (2014-09-24 19:43:13 UTC) #2
davidben
lgtm
6 years, 2 months ago (2014-09-26 15:28:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/605473002/1
6 years, 2 months ago (2014-09-26 15:33:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as ffee7790e380753b8c08bf3cf69e1d79f1fcb52a
6 years, 2 months ago (2014-09-26 15:37:24 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 15:38:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e1d803bda102882f6afebab7d6bce04d262c8d7
Cr-Commit-Position: refs/heads/master@{#296947}

Powered by Google App Engine
This is Rietveld 408576698