Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 605463002: Truncate long extension titles for webstore installs. (Closed)

Created:
6 years, 3 months ago by Avi (use Gerrit)
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek, Devlin
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Truncate long extension titles for webstore installs. XIB change: * Sets the header field to be truncated rather than wrapped. BUG=417317 TEST=as in bug Committed: https://crrev.com/04cc6d8b71d8e2fd425a08c3f671922d7ce1d660 Cr-Commit-Position: refs/heads/master@{#296714}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M chrome/app/nibs/ExtensionInstallPromptWebstoreData.xib View 3 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Avi (use Gerrit)
rsesek: Mac review rdevlin: Extensions review
6 years, 3 months ago (2014-09-24 19:39:56 UTC) #2
Devlin
On 2014/09/24 19:39:56, Avi wrote: > rsesek: Mac review > rdevlin: Extensions review screenshots in ...
6 years, 3 months ago (2014-09-24 20:08:57 UTC) #3
Robert Sesek
LGTM
6 years, 2 months ago (2014-09-25 14:57:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/605463002/1
6 years, 2 months ago (2014-09-25 15:22:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 18d8c532ccee6b0fd7b63e278ae5699de6edc95f
6 years, 2 months ago (2014-09-25 16:03:45 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 16:04:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04cc6d8b71d8e2fd425a08c3f671922d7ce1d660
Cr-Commit-Position: refs/heads/master@{#296714}

Powered by Google App Engine
This is Rietveld 408576698