mojo/public/tools/bindings/generators/mojom_js_generator.py - Issue 605443002: The default value for NullableString should be null (was "")

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/mojom_js_generator.py

Issue 605443002: The default value for NullableString should be null (was "") (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added missing types, renamed test functions and struct types Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/mojom_cpp_generator.py ('k') | mojo/public/tools/bindings/pylib/mojom/generate/module.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/mojom_js_generator.py

diff --git a/mojo/public/tools/bindings/generators/mojom_js_generator.py b/mojo/public/tools/bindings/generators/mojom_js_generator.py

index 18209977d1438b5e6a05460993f453e6291a385e..c9109fbbec3694462a22ed78f8efccdcd2b08c11 100644

--- a/mojo/public/tools/bindings/generators/mojom_js_generator.py

+++ b/mojo/public/tools/bindings/generators/mojom_js_generator.py

@@ -31,8 +31,8 @@ _kind_to_javascript_default_value = {

mojom.INT64: "0",

mojom.UINT64: "0",

mojom.DOUBLE: "0",

- mojom.STRING: '""',

- mojom.NULLABLE_STRING: '""'

+ mojom.STRING: "null",

+ mojom.NULLABLE_STRING: "null"

}