Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: mojo/public/js/bindings/codec_unittests.js

Issue 605443002: The default value for NullableString should be null (was "") (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added missing types, renamed test functions and struct types Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 define([ 5 define([
6 "gin/test/expect", 6 "gin/test/expect",
7 "mojo/public/js/bindings/codec", 7 "mojo/public/js/bindings/codec",
8 "mojo/public/interfaces/bindings/tests/rect.mojom", 8 "mojo/public/interfaces/bindings/tests/rect.mojom",
9 "mojo/public/interfaces/bindings/tests/sample_service.mojom", 9 "mojo/public/interfaces/bindings/tests/sample_service.mojom",
10 "mojo/public/interfaces/bindings/tests/test_structs.mojom", 10 "mojo/public/interfaces/bindings/tests/test_structs.mojom",
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 builder.encodeStruct(cls, input) 181 builder.encodeStruct(cls, input)
182 var message = builder.finish(); 182 var message = builder.finish();
183 183
184 var reader = new codec.MessageReader(message); 184 var reader = new codec.MessageReader(message);
185 expect(reader.payloadSize).toBe(payloadSize); 185 expect(reader.payloadSize).toBe(payloadSize);
186 expect(reader.messageName).toBe(messageName); 186 expect(reader.messageName).toBe(messageName);
187 var result = reader.decodeStruct(cls); 187 var result = reader.decodeStruct(cls);
188 expect(result).toEqual(expectedResult); 188 expect(result).toEqual(expectedResult);
189 } 189 }
190 encodeDecode(codec.String, "banana", "banana", 24); 190 encodeDecode(codec.String, "banana", "banana", 24);
191 encodeDecode(codec.NullableString, null, null, 8);
191 encodeDecode(codec.Int8, -1, -1); 192 encodeDecode(codec.Int8, -1, -1);
192 encodeDecode(codec.Int8, 0xff, -1); 193 encodeDecode(codec.Int8, 0xff, -1);
193 encodeDecode(codec.Int16, -1, -1); 194 encodeDecode(codec.Int16, -1, -1);
194 encodeDecode(codec.Int16, 0xff, 0xff); 195 encodeDecode(codec.Int16, 0xff, 0xff);
195 encodeDecode(codec.Int16, 0xffff, -1); 196 encodeDecode(codec.Int16, 0xffff, -1);
196 encodeDecode(codec.Int32, -1, -1); 197 encodeDecode(codec.Int32, -1, -1);
197 encodeDecode(codec.Int32, 0xffff, 0xffff); 198 encodeDecode(codec.Int32, 0xffff, 0xffff);
198 encodeDecode(codec.Int32, 0xffffffff, -1); 199 encodeDecode(codec.Int32, 0xffffffff, -1);
199 encodeDecode(codec.Float, 1.0, 1.0); 200 encodeDecode(codec.Float, 1.0, 1.0);
200 encodeDecode(codec.Double, 1.0, 1.0); 201 encodeDecode(codec.Double, 1.0, 1.0);
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 expect(actualMemory.length).toEqual(expectedMemory.length); 249 expect(actualMemory.length).toEqual(expectedMemory.length);
249 expect(actualMemory).toEqual(expectedMemory); 250 expect(actualMemory).toEqual(expectedMemory);
250 251
251 var reader = new codec.MessageReader(message); 252 var reader = new codec.MessageReader(message);
252 expect(reader.payloadSize).toBe(payloadSize); 253 expect(reader.payloadSize).toBe(payloadSize);
253 expect(reader.messageName).toBe(messageName); 254 expect(reader.messageName).toBe(messageName);
254 var str2 = reader.decoder.decodeStringPointer(); 255 var str2 = reader.decoder.decodeStringPointer();
255 expect(str2).toEqual(str); 256 expect(str2).toEqual(str);
256 } 257 }
257 }); 258 });
OLDNEW
« no previous file with comments | « mojo/public/interfaces/bindings/tests/test_structs.mojom ('k') | mojo/public/js/bindings/struct_unittests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698