Issue 605383002: Fix lint targets 'properly' in build/android/buildbot/bb_device_steps.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 605383002: Fix lint targets 'properly' in build/android/buildbot/bb_device_steps.py (Closed)

Created:
6 years, 2 months ago by Dirk Pranke

Modified:
6 years, 2 months ago

Reviewers:
cmp, tfarina

CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, Mads Ager (chromium), ppi, Fabrice (no longer in Chrome)

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Fix lint targets 'properly' in build/android/buildbot/bb_device_steps.py Blink's lint-test-expectations script doesn't actually require any command line args, and we shouldn't generally use them on the bots. TBR=cmp@chromium.org, tfarina@chromium.org BUG=338338, 418017 Committed: https://crrev.com/ec3eb0ad503aa7df6772b6ca9881ed6ff3057338 Cr-Commit-Position: refs/heads/master@{#297043}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	build/android/buildbot/bb_device_steps.py	View		3 chunks	+3 lines, -4 lines	0 comments	Download

Total messages: 7 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/605383002/1

6 years, 2 months ago (2014-09-26 20:43:46 UTC) #3

commit-bot: I haz the power

Committed patchset #1 (id:1) as d057ab2f705d3abaacacf0133690515af0187ba8

6 years, 2 months ago (2014-09-26 21:43:10 UTC) #6

commit-bot: I haz the power

6 years, 2 months ago (2014-09-26 21:44:04 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ec3eb0ad503aa7df6772b6ca9881ed6ff3057338
Cr-Commit-Position: refs/heads/master@{#297043}