Chromium flag to enable accelerated YUV decoding

Chromium flag to enable accelerated YUV decoding

BUG=

Committed: https://crrev.com/cc2f4d8feaa8b859ba518ce57ef5f9f389e4d6c2
Cr-Commit-Position: refs/heads/master@{#297689}

[sugoi1, 2014-09-26 20:26:03]

sugoi@chromium.org changed reviewers:
+ senorblanco@google.com

[sugoi1, 2014-09-26 20:26:03]

Sending it to you for review now, even though it will require this blink patch
before it can land:
https://codereview.chromium.org/609923003/

[Stephen White, 2014-09-26 20:41:31]

senorblanco@chromium.org changed reviewers:
+ senorblanco@chromium.org

[Stephen White, 2014-09-26 20:41:31]

https://codereview.chromium.org/605373002/diff/1/content/public/common/common...
File content/public/common/common_param_traits_macros.h (right):

https://codereview.chromium.org/605373002/diff/1/content/public/common/common...
content/public/common/common_param_traits_macros.h:166:
IPC_STRUCT_TRAITS_MEMBER(decode_to_yuv_enabled)
Maybe this (and everything Chrome-side) should be 
"accelerated_jpeg_decoding_enabled" (since it might include more than
YUV later on?)

https://codereview.chromium.org/605373002/diff/1/content/public/common/conten...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/605373002/diff/1/content/public/common/conten...
content/public/common/content_switches.cc:282: // Has no effect unless also
using --force-gpu-rasterization.
Technically, this isn't true: you could also get there with the meta
tag + device whitelist.

Maybe "unless GPU rasterization is enabled"?

[sugoi1, 2014-09-29 14:57:27]

https://codereview.chromium.org/605373002/diff/1/content/public/common/common...
File content/public/common/common_param_traits_macros.h (right):

https://codereview.chromium.org/605373002/diff/1/content/public/common/common...
content/public/common/common_param_traits_macros.h:166:
IPC_STRUCT_TRAITS_MEMBER(decode_to_yuv_enabled)
On 2014/09/26 20:41:31, Stephen White wrote:
> Maybe this (and everything Chrome-side) should be 
> "accelerated_jpeg_decoding_enabled" (since it might include more than
> YUV later on?)

Done.

https://codereview.chromium.org/605373002/diff/1/content/public/common/conten...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/605373002/diff/1/content/public/common/conten...
content/public/common/content_switches.cc:282: // Has no effect unless also
using --force-gpu-rasterization.
On 2014/09/26 20:41:31, Stephen White wrote:
> Technically, this isn't true: you could also get there with the meta
> tag + device whitelist.
> 
> Maybe "unless GPU rasterization is enabled"?

Done.

[sugoi1, 2014-09-30 18:47:03]

sugoi@chromium.org changed reviewers:
+ piman@google.com

[sugoi1, 2014-09-30 18:47:05]

Adding piman@ to get a review from an owner.

[piman, 2014-09-30 20:57:14]

piman@chromium.org changed reviewers:
+ piman@chromium.org

[piman, 2014-09-30 20:57:14]

https://codereview.chromium.org/605373002/diff/20001/content/public/common/co...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/605373002/diff/20001/content/public/common/co...
content/public/common/content_switches.cc:284:
"enable-accelerated-jpeg-decoding";
Can you add this to  chrome/browser/chromeos/login/chrome_restart_request.cc, so
that it also applies to chrome os guest mode?

[sugoi1, 2014-10-01 14:35:24]

https://codereview.chromium.org/605373002/diff/20001/content/public/common/co...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/605373002/diff/20001/content/public/common/co...
content/public/common/content_switches.cc:284:
"enable-accelerated-jpeg-decoding";
On 2014/09/30 20:57:14, piman (Very slow to review) wrote:
> Can you add this to  chrome/browser/chromeos/login/chrome_restart_request.cc,
so
> that it also applies to chrome os guest mode?

Done.

[piman, 2014-10-01 15:08:15]

LGTM, thanks!

[sugoi1, 2014-10-01 15:13:40]

The CQ bit was checked by sugoi@chromium.org

[commit-bot: I haz the power, 2014-10-01 15:14:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/605373002/40001

[commit-bot: I haz the power, 2014-10-01 17:31:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-01 17:31:26]

Try jobs failed on following builders:
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[sugoi1, 2014-10-01 17:33:15]

The CQ bit was checked by sugoi@chromium.org

[commit-bot: I haz the power, 2014-10-01 17:35:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/605373002/40001

[commit-bot: I haz the power, 2014-10-01 19:21:35]

Committed patchset #3 (id:40001) as 16350f3db4dcdedc3389310b87f02787859f0a05

[commit-bot: I haz the power, 2014-10-01 19:22:33]

Patchset 3 (id:??) landed as
https://crrev.com/cc2f4d8feaa8b859ba518ce57ef5f9f389e4d6c2
Cr-Commit-Position: refs/heads/master@{#297689}