Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 605363002: Add a new UMA to GCM (Closed)

Created:
6 years, 2 months ago by jianli
Modified:
6 years, 2 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a new UMA to GCM This is used to find out the GCM usage from non-signed-in users. BUG=384041 TEST=none Committed: https://crrev.com/9a5d1544434f81316604dc8b35fb6380d0d5a773 Cr-Commit-Position: refs/heads/master@{#297045}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M components/gcm_driver/gcm_driver_desktop.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jianli
asvitkine for new UMA zea for GCM hookup
6 years, 2 months ago (2014-09-26 19:00:49 UTC) #2
Alexei Svitkine (slow)
lgtm
6 years, 2 months ago (2014-09-26 19:59:52 UTC) #3
Nicolas Zea
LGTM with some nits https://codereview.chromium.org/605363002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/605363002/diff/1/tools/metrics/histograms/histograms.xml#newcode9231 tools/metrics/histograms/histograms.xml:9231: + Indicates whether the user ...
6 years, 2 months ago (2014-09-26 20:30:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/605363002/20001
6 years, 2 months ago (2014-09-26 20:38:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 83f433b84acbd2cb53a123672e9a1c754c366a7f
6 years, 2 months ago (2014-09-26 21:50:36 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 21:51:19 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9a5d1544434f81316604dc8b35fb6380d0d5a773
Cr-Commit-Position: refs/heads/master@{#297045}

Powered by Google App Engine
This is Rietveld 408576698