Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 605273004: Use static_assert unconditionally. (Closed)

Created:
6 years, 2 months ago by Peter Kasting
Modified:
6 years, 2 months ago
Reviewers:
jam
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Use static_assert unconditionally. BUG=none TEST=none R=jam@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/1b24b697659b9b933f336238665c835497464a0b

Patch Set 1 #

Patch Set 2 : Add to AUTHORS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -128 lines) Patch
M AUTHORS View 1 1 chunk +31 lines, -30 lines 0 comments Download
M third_party/macros.h View 1 chunk +31 lines, -98 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Peter Kasting
6 years, 2 months ago (2014-09-27 00:16:44 UTC) #2
jam
lgtm
6 years, 2 months ago (2014-09-27 00:58:37 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years, 2 months ago (2014-09-27 01:07:59 UTC) #6
Peter Kasting
6 years, 2 months ago (2014-09-27 01:09:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1b24b697659b9b933f336238665c835497464a0b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698