Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 605273002: Fix undef test to use Subzero's bitcode reader. (Closed)

Created:
6 years, 2 months ago by Karl
Modified:
6 years, 2 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Fix undef test to use Subzero's bitcode reader. This test was previously failing because insertelement returned the wrong type. However, a previous CL fixed this problem and the test now works with Subzero's bitcode reader. BUG=None R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=b1b1736585f87f15888ea256fb40775093effe31

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M tests_lit/llvm2ice_tests/undef.ll View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Karl
6 years, 2 months ago (2014-09-26 15:57:02 UTC) #2
Jim Stichnoth
lgtm
6 years, 2 months ago (2014-09-26 16:04:51 UTC) #3
Karl
Committed patchset #1 (id:1) manually as b1b1736 (presubmit successful).
6 years, 2 months ago (2014-09-26 16:15:32 UTC) #4
Karl
6 years, 2 months ago (2014-09-26 16:15:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as b1b1736 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698