Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: net/quic/quic_connection.cc

Issue 605263003: Remove OnPacketRetransmitted from QuicConnectionDebugVisitor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Final_0925
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_connection.h ('k') | net/quic/quic_connection_logger.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection.cc
diff --git a/net/quic/quic_connection.cc b/net/quic/quic_connection.cc
index 46e6ea137193110c255c46c9eaac4b41e397dcf1..5e964f8a0810852c33f25965ac4a753a45ee6732 100644
--- a/net/quic/quic_connection.cc
+++ b/net/quic/quic_connection.cc
@@ -1346,8 +1346,6 @@ bool QuicConnection::WritePacketInner(QueuedPacket* packet) {
QuicPacketSequenceNumber sequence_number =
packet->serialized_packet.sequence_number;
- // Some encryption algorithms require the packet sequence numbers not be
- // repeated.
DCHECK_LE(sequence_number_of_last_sent_packet_, sequence_number);
sequence_number_of_last_sent_packet_ = sequence_number;
@@ -1407,6 +1405,7 @@ bool QuicConnection::WritePacketInner(QueuedPacket* packet) {
if (debug_visitor_.get() != NULL) {
// Pass the write result to the visitor.
debug_visitor_->OnPacketSent(sequence_number,
+ packet->original_sequence_number,
packet->encryption_level,
packet->transmission_type,
*encrypted,
@@ -1438,10 +1437,6 @@ bool QuicConnection::WritePacketInner(QueuedPacket* packet) {
sent_packet_manager_.least_packet_awaited_by_peer(),
sent_packet_manager_.GetCongestionWindow());
- if (packet->original_sequence_number != 0 && debug_visitor_.get() != NULL) {
- debug_visitor_->OnPacketRetransmitted(
- packet->original_sequence_number, sequence_number);
- }
bool reset_retransmission_alarm = sent_packet_manager_.OnPacketSent(
&packet->serialized_packet,
packet->original_sequence_number,
« no previous file with comments | « net/quic/quic_connection.h ('k') | net/quic/quic_connection_logger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698