Extend EME player_utils.js to support onEncrypted.

Extend player_utils.js to support "encrypted" event in addition to "needkey".

BUG=224786
Committed: https://crrev.com/b4c0e5d03dede0a528b08adfcbbe0cfe994dc984
Cr-Commit-Position: refs/heads/master@{#297295}

[sandersd (OOO until July 31), 2014-09-26 22:59:56]

sandersd@chromium.org changed reviewers:
+ ddorwin@chromium.org

[ddorwin, 2014-09-26 23:10:49]

LG once code review references are removed from code and CL description.

https://codereview.chromium.org/605243004/diff/1/media/test/data/eme_player_j...
File media/test/data/eme_player_js/player_utils.js (right):

https://codereview.chromium.org/605243004/diff/1/media/test/data/eme_player_j...
media/test/data/eme_player_js/player_utils.js:57: // TODO(sandersd): Stop
checking contentType once CL 600143005 lands.
We don't reference Reitveld issue numbers in code. Also, we generally use the
full URL in the message, but don't mention it in the description that goes in
the commit log. Maybe there is a bug number - then you can say when
crbug.com/XXXXXXXX is fixed.
(Also, you need a DEPS roll after that CL lands in Blink.)

https://codereview.chromium.org/605243004/diff/1/media/test/data/eme_player_j...
media/test/data/eme_player_js/player_utils.js:85: // TODO(sandersd): Stop
registering needkey once CL 600143005 lands.
ditto

[sandersd (OOO until July 31), 2014-09-26 23:16:42]

https://codereview.chromium.org/605243004/diff/1/media/test/data/eme_player_j...
File media/test/data/eme_player_js/player_utils.js (right):

https://codereview.chromium.org/605243004/diff/1/media/test/data/eme_player_j...
media/test/data/eme_player_js/player_utils.js:57: // TODO(sandersd): Stop
checking contentType once CL 600143005 lands.
On 2014/09/26 23:10:48, ddorwin wrote:
> We don't reference Reitveld issue numbers in code. Also, we generally use the
> full URL in the message, but don't mention it in the description that goes in
> the commit log. Maybe there is a bug number - then you can say when
> crbug.com/XXXXXXXX is fixed.
> (Also, you need a DEPS roll after that CL lands in Blink.)

Done.

https://codereview.chromium.org/605243004/diff/1/media/test/data/eme_player_j...
media/test/data/eme_player_js/player_utils.js:85: // TODO(sandersd): Stop
registering needkey once CL 600143005 lands.
On 2014/09/26 23:10:49, ddorwin wrote:
> ditto

Done.

[ddorwin, 2014-09-26 23:51:47]

LGTM % comments.

https://codereview.chromium.org/605243004/diff/20001/media/test/data/eme_play...
File media/test/data/eme_player_js/player_utils.js (right):

https://codereview.chromium.org/605243004/diff/20001/media/test/data/eme_play...
media/test/data/eme_player_js/player_utils.js:57: // TODO(sandersd): Stop
checking contentType once needkey is gone.
nit: It's really once we switch to the new encrypted event type for unprefixed.
IOW, it's not clear from this message that this doesn't include prefixed or that
you care more about the type than the event name.

https://codereview.chromium.org/605243004/diff/20001/media/test/data/eme_play...
media/test/data/eme_player_js/player_utils.js:85: // TODO(sandersd): Stop
registering needkey.
... after it is renamed.

[sandersd (OOO until July 31), 2014-09-26 23:57:15]

https://codereview.chromium.org/605243004/diff/20001/media/test/data/eme_play...
File media/test/data/eme_player_js/player_utils.js (right):

https://codereview.chromium.org/605243004/diff/20001/media/test/data/eme_play...
media/test/data/eme_player_js/player_utils.js:57: // TODO(sandersd): Stop
checking contentType once needkey is gone.
On 2014/09/26 23:51:46, ddorwin wrote:
> nit: It's really once we switch to the new encrypted event type for
unprefixed.
> IOW, it's not clear from this message that this doesn't include prefixed or
that
> you care more about the type than the event name.

Done.

https://codereview.chromium.org/605243004/diff/20001/media/test/data/eme_play...
media/test/data/eme_player_js/player_utils.js:85: // TODO(sandersd): Stop
registering needkey.
On 2014/09/26 23:51:46, ddorwin wrote:
> ... after it is renamed.

Done.

[ddorwin, 2014-09-27 00:01:54]

lgtm

[sandersd (OOO until July 31), 2014-09-29 21:43:19]

The CQ bit was checked by sandersd@chromium.org

[commit-bot: I haz the power, 2014-09-29 21:45:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/605243004/40001

[commit-bot: I haz the power, 2014-09-29 22:56:07]

Committed patchset #3 (id:40001) as 3b8f0fb134ba9b959efef9c4d162867792561b19

[commit-bot: I haz the power, 2014-09-29 22:57:53]

Patchset 3 (id:??) landed as
https://crrev.com/b4c0e5d03dede0a528b08adfcbbe0cfe994dc984
Cr-Commit-Position: refs/heads/master@{#297295}