Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 605243003: Add base::Reversed() as an adapter for range-based for loops in reverse (Closed)

Created:
6 years, 2 months ago by mdempsky
Modified:
6 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add base::Reversed() as an adapter for range-based for loops in reverse See also https://groups.google.com/a/chromium.org/d/msg/chromium-dev/utDItV2a7aE/IeVDbl5L77cJ Committed: https://crrev.com/ae846887d618ba498e64d79de606c8851e62f6da Cr-Commit-Position: refs/heads/master@{#297216}

Patch Set 1 #

Patch Set 2 : Move to base/containers/adapters.h #

Patch Set 3 : Fix MSVC build (hopefully) #

Patch Set 4 : Test that references point to the intended objects #

Patch Set 5 : Explicit copy constructor and explicitly disallow operator= #

Total comments: 8

Patch Set 6 : Respond to brettw feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -0 lines) Patch
M base/BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download
M base/base.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M base/base.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
A base/containers/adapters.h View 1 2 3 4 5 1 chunk +50 lines, -0 lines 0 comments Download
A base/containers/adapters_unittest.cc View 1 2 3 4 5 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
mdempsky
6 years, 2 months ago (2014-09-26 22:10:44 UTC) #2
brettw
https://codereview.chromium.org/605243003/diff/80001/base/containers/adapters.h File base/containers/adapters.h (right): https://codereview.chromium.org/605243003/diff/80001/base/containers/adapters.h#newcode5 base/containers/adapters.h:5: // This file contains adapters to iterate containers in ...
6 years, 2 months ago (2014-09-29 16:55:14 UTC) #3
mdempsky
https://codereview.chromium.org/605243003/diff/80001/base/containers/adapters.h File base/containers/adapters.h (right): https://codereview.chromium.org/605243003/diff/80001/base/containers/adapters.h#newcode5 base/containers/adapters.h:5: // This file contains adapters to iterate containers in ...
6 years, 2 months ago (2014-09-29 17:47:41 UTC) #4
brettw
lgtm
6 years, 2 months ago (2014-09-29 18:19:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/605243003/100001
6 years, 2 months ago (2014-09-29 18:22:34 UTC) #7
commit-bot: I haz the power
Committed patchset #6 (id:100001) as d58c284f3105026a24f8488a4c3953389674851b
6 years, 2 months ago (2014-09-29 18:48:21 UTC) #8
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/ae846887d618ba498e64d79de606c8851e62f6da Cr-Commit-Position: refs/heads/master@{#297216}
6 years, 2 months ago (2014-09-29 18:49:30 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 18:49:33 UTC) #10
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/ae846887d618ba498e64d79de606c8851e62f6da
Cr-Commit-Position: refs/heads/master@{#297216}

Powered by Google App Engine
This is Rietveld 408576698