Explicitly depend on ICU to fix GPU isolate races.

chrome/chrome_tests.gypi

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 {
   'includes': [
     'js_unittest_vars.gypi',
   ],
   'targets': [
     {
       'target_name': 'interactive_ui_tests',
@@ skipping 2928 matching lines @@
           ],
           'sources': [
             'sync_integration_tests.isolate',
           ],
         },
       ],
       'conditions': [
         ['archive_gpu_tests==1', {
           'targets': [
             {
+              'target_name': 'gpu_tests_base',
+              'type': 'none',
+              'dependencies': [
+                # depend on icu to fix races. http://crbug.com/417583

[M-A Ruel, 2014/09/26 18:01:59]

AFAIK it's not a TODO so no need to list the bug or even comment.

+                '../third_party/icu/icu.gyp:icudata',

[Ken Russell (switch to Gerrit), 2014/09/26 17:54:00]

Consider depending on '../third_party/icu/icu.gyp:icui18n' and
'../third_party/icu/icu.gyp:icuuc' instead to more closely match the other
targets in this file.

+              ],
+              'direct_dependent_settings': {
+                'includes': [
+                  '../build/isolate.gypi',
+                ],
+              },
+            },
+            {
               'target_name': 'angle_unittests_run',
               'type': 'none',
               'dependencies': [
                 '../gpu/gpu.gyp:angle_unittests',
+                'gpu_tests_base',
               ],
               'includes': [
-                '../build/isolate.gypi',
                 'angle_unittests.isolate',
               ],
               'sources': [
                 'angle_unittests.isolate',
               ],
             },
             {
               'target_name': 'gl_tests_run',
               'type': 'none',
               'dependencies': [
                 '../gpu/gpu.gyp:gl_tests',
+                'gpu_tests_base',
               ],
               'includes': [
-                '../build/isolate.gypi',
                 'gl_tests.isolate',
               ],
               'sources': [
                 'gl_tests.isolate',
               ],
             },
             {
               'target_name': 'tab_capture_end2end_tests_run',
               'type': 'none',
               'dependencies': [
                 'browser_tests_run',
+                'gpu_tests_base',
               ],
               'includes': [
-                '../build/isolate.gypi',
                 'tab_capture_end2end_tests.isolate',
               ],
               'sources': [
                 'tab_capture_end2end_tests.isolate',
               ],
             },
             {
               'target_name': 'telemetry_gpu_test_run',
               'type': 'none',
               'dependencies': [
                 'chrome_run',
                 '../tools/telemetry/telemetry.gyp:bitmaptools#host',
+                'gpu_tests_base',
               ],
               'includes': [
-                '../build/isolate.gypi',
                 'telemetry_gpu_test.isolate',
               ],
               'sources': [
                 'telemetry_gpu_test.isolate',
               ],
             },
             {
               'target_name': 'gpu_unittests_run',
               'type': 'none',
               'dependencies': [
                 '../gpu/gpu.gyp:gpu_unittests',
+                'gpu_tests_base',
               ],
               'includes': [
-                '../build/isolate.gypi',
                 'gpu_unittests.isolate',
               ],
               'sources': [
                 'gpu_unittests.isolate',
               ],
             },
           ],
           'conditions': [
             ['internal_gles2_conform_tests==1', {
               'targets': [
                 {
                   'target_name': 'gles2_conform_test_run',
                   'type': 'none',
                   'dependencies': [
                     '../gpu/gles2_conform_support/gles2_conform_test.gyp:gles2_conform_test',
+                    'gpu_tests_base',
                   ],
                   'includes': [
-                    '../build/isolate.gypi',
                     'gles2_conform_test.isolate',
                   ],
                   'sources': [
                     'gles2_conform_test.isolate',
                   ],
                 },
               ],
             }],
           ],
         }],
@@ skipping 17 matching lines @@
             ['enable_webrtc==1', {
               'dependencies': [
                 '../third_party/libjingle/libjingle.gyp:libjingle_webrtc'
               ]
             }],
           ],
         }]
     }],
   ],  # 'conditions'
 }