Change restrictions on start/end on String.fromCharCodes.

tests/corelib/string_fromcharcodes_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import "package:expect/expect.dart";
 import "dart:typed_data";
 
 main() {
   iter(count, [values]) => values is List
                                ? new Iterable.generate(count, (x) => values[x])
@@ skipping 86 matching lines @@
   test(tailSurrogate, new Uint16List(1)..[0] = 0xDFFF);
   test(tailSurrogate, new Uint32List(1)..[0] = 0xDFFF);
   test(tailSurrogate, tailSurrogate.codeUnits);
 
   testThrows(null);
   testThrows("not an iterable");
   testThrows(42);
   testThrows([-1]);
   testThrows(new List(1)..[0] = -1);
   testThrows(const [-1]);
-  //testThrows(new Int8List(1)..[0] = -1);
+  testThrows(new Int8List(1)..[0] = -1);
   testThrows(new Int16List(1)..[0] = -1);
   testThrows(new Int32List(1)..[0] = -1);
   testThrows([0x110000]);
   testThrows(new List(1)..[0] = 0x110000);
   testThrows(const [0x110000]);
   testThrows(new Int32List(1)..[0] = 0x110000);
 
   // Check start/end
   var list = const[0x41, 0x42, 0x43, 0x44, 0x45, 0x46, 0x47, 0x48];
   for (var iterable in [
            iter(list.length, list),
            list.toList(growable: true),
            list.toList(growable: false),
            list,
            new Uint8List(8)..setRange(0, 8, list),
            new Uint16List(8)..setRange(0, 8, list),
            new Uint32List(8)..setRange(0, 8, list),
            "ABCDEFGH".codeUnits,
        ]) {
     test("ABCDEFGH", iterable);
     // start varies, end is null.
     test("ABCDEFGH", iterable, 0);
     test("BCDEFGH", iterable, 1);
     test("H", iterable, 7);
     test("", iterable, 8);
-    test("", iterable, 9);
     // start = 0, end varies.
     test("ABCDEFGH", iterable, 0);
     test("A", iterable, 0, 1);
     test("AB", iterable, 0, 2);
     test("ABCDEFG", iterable, 0, 7);
     test("ABCDEFGH", iterable, 0, 8);
-    test("ABCDEFGH", iterable, 0, 9);
     test("", iterable, 0, 0);
-    test("", iterable, 0, -1);
     // Both varying.
     test("ABCDEFGH", iterable, 0, 8);
-    test("ABCDEFGH", iterable, 0, 9);
     test("AB", iterable, 0, 2);
     test("GH", iterable, 6, 8);
     test("DE", iterable, 3, 5);
     test("", iterable, 3, 3);
-    test("", iterable, 5, 3);
-    test("", iterable, 4, -1);
-    test("", iterable, 8, -1);
-    test("", iterable, 0, -1);
-    test("", iterable, 9, 9);
   }
   // Can split surrogates in input, but not a single big code point.
   test(leadSurrogate, [0xDBFF, 0xDFFF], 0, 1);
   test(tailSurrogate, [0xDBFF, 0xDFFF], 1);
   test("\u{10FFFF}", [0x10FFFF], 0, 1);
 
   // Test varying slices of the code units of a string.
   testSubstring(string) {
     var codes = string.codeUnits;
     int length = string.length;
     for (var iterable in [
             iter(length, codes),
             codes.toList(growable: true),
             codes.toList(growable: false),
             new Uint16List(length)..setRange(0, length, codes),
             new Int32List(length)..setRange(0, length, codes),
             new Uint32List(length)..setRange(0, length, codes),
             codes,
         ]) {
       var newString = new String.fromCharCodes(iterable);
       Expect.equals(string, newString);
       for (int i = 0; i < length; i = i * 2 + 1) {
         test(string.substring(i), iterable, i);
         test(string.substring(0, i), iterable, 0, i);
         for (int j = 0; i + j < length; j = j * 2 + 1) {
           test(string.substring(i, i + j), iterable, i, i + j);
         }
       }
-      Expect.equals(string, new String.fromCharCodes(iterable, 0, length + 1));
+
+      Expect.throws(() => new String.fromCharCodes(iterable, -1));
+      Expect.throws(() => new String.fromCharCodes(iterable, 0, -1));
+      Expect.throws(() => new String.fromCharCodes(iterable, 2, 1));
+      Expect.throws(() => new String.fromCharCodes(iterable, 0, length + 1));
+      Expect.throws(() => new String.fromCharCodes(iterable, length + 1));
+      Expect.throws(() => new String.fromCharCodes(iterable, length + 1,
+                                                             length + 2));
     }
   }
 
   testSubstring("");
   testSubstring("ABCDEFGH");
   // length > 128
   testSubstring("ABCDEFGH" * 33);
   testSubstring("\x00" * 357);
   // length > 128 and non-ASCII.
   testSubstring("\uFFFD\uFFFE\u{10000}\u{10ffff}c\x00" * 37);
 }