Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 605183002: Android Video Capture: Using full class path for Camera+subclasses to avoid @deprecation warnings (Closed)

Created:
6 years, 2 months ago by mcasas
Modified:
6 years, 2 months ago
Reviewers:
magjed_chromium
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Android Video Capture: Using full class path for Camera+subclasses to avoid @deprecation warnings Since @SuppressWarnings("deprecated") doesn't work for import statements, the only option is to use the fully qualified class path in every reference. To be sure, two deprecation warnings still remain, namely in the use of public abstract class VideoCapture implements android.hardware.Camera.PreviewCallback { That somehow is not covered by the suppression. TBR=qinmin@chromium.org BUG=398669 Committed: https://crrev.com/dc59e54250458563e3e2d5990dd74089adc44c70 Cr-Commit-Position: refs/heads/master@{#296918}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -48 lines) Patch
M media/base/android/java/src/org/chromium/media/VideoCapture.java View 9 chunks +17 lines, -18 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/VideoCaptureAndroid.java View 6 chunks +10 lines, -12 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/VideoCaptureFactory.java View 5 chunks +10 lines, -10 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/VideoCaptureTango.java View 1 4 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mcasas
magjed@ PTAL
6 years, 2 months ago (2014-09-26 09:21:31 UTC) #2
magjed_chromium
lgtm
6 years, 2 months ago (2014-09-26 09:48:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/605183002/20001
6 years, 2 months ago (2014-09-26 11:04:22 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 012230f6abcebc448894dfa6bfb6c4ed2fbaad47
6 years, 2 months ago (2014-09-26 11:44:41 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 11:45:16 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dc59e54250458563e3e2d5990dd74089adc44c70
Cr-Commit-Position: refs/heads/master@{#296918}

Powered by Google App Engine
This is Rietveld 408576698