chrome/test/chromedriver/chrome/web_view_impl.cc - Issue 605143002: [chromedriver] Accept git hashes in blink version strings from devtools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/web_view_impl.cc

Issue 605143002: [chromedriver] Accept git hashes in blink version strings from devtools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix review nits Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/chromedriver/chrome/web_view_impl.cc

diff --git a/chrome/test/chromedriver/chrome/web_view_impl.cc b/chrome/test/chromedriver/chrome/web_view_impl.cc

index eb78c9ffb27c4aa9aaf871cfe0506999eb9f4cdb..55c035f4b4beed39f38e1e61339a4529fae7226e 100644

--- a/chrome/test/chromedriver/chrome/web_view_impl.cc

+++ b/chrome/test/chromedriver/chrome/web_view_impl.cc

@@ -13,6 +13,7 @@

#include "base/threading/platform_thread.h"

#include "base/time/time.h"

#include "base/values.h"

+#include "chrome/test/chromedriver/chrome/browser_info.h"

#include "chrome/test/chromedriver/chrome/debugger_tracker.h"

#include "chrome/test/chromedriver/chrome/devtools_client_impl.h"

#include "chrome/test/chromedriver/chrome/dom_tracker.h"

@@ -25,7 +26,6 @@

#include "chrome/test/chromedriver/chrome/navigation_tracker.h"

#include "chrome/test/chromedriver/chrome/status.h"

#include "chrome/test/chromedriver/chrome/ui_events.h"

-#include "chrome/test/chromedriver/chrome/version.h"

namespace {

« no previous file with comments | « chrome/test/chromedriver/chrome/version.cc ('k') | chrome/test/chromedriver/commands.cc » ('j') | no next file with comments »