chrome/test/chromedriver/chrome/mobile_emulation_override_manager.cc - Issue 605143002: [chromedriver] Accept git hashes in blink version strings from devtools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/mobile_emulation_override_manager.cc

Issue 605143002: [chromedriver] Accept git hashes in blink version strings from devtools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix review nits Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/chrome/devtools_http_client_unittest.cc ('k') | chrome/test/chromedriver/chrome/mobile_emulation_override_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/mobile_emulation_override_manager.cc

diff --git a/chrome/test/chromedriver/chrome/mobile_emulation_override_manager.cc b/chrome/test/chromedriver/chrome/mobile_emulation_override_manager.cc

index 6d2889948868a988cd7f988be2a04d0a79c731dd..6b31d9ecdace7ff1d331beb36789d775d0d9723d 100644

--- a/chrome/test/chromedriver/chrome/mobile_emulation_override_manager.cc

+++ b/chrome/test/chromedriver/chrome/mobile_emulation_override_manager.cc

@@ -2,12 +2,13 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+#include "chrome/test/chromedriver/chrome/mobile_emulation_override_manager.h"

#include "base/values.h"

+#include "chrome/test/chromedriver/chrome/browser_info.h"

#include "chrome/test/chromedriver/chrome/device_metrics.h"

#include "chrome/test/chromedriver/chrome/devtools_client.h"

-#include "chrome/test/chromedriver/chrome/mobile_emulation_override_manager.h"

#include "chrome/test/chromedriver/chrome/status.h"

-#include "chrome/test/chromedriver/chrome/version.h"

MobileEmulationOverrideManager::MobileEmulationOverrideManager(

DevToolsClient* client,