Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1870)

Unified Diff: chrome/test/chromedriver/chrome/devtools_http_client.h

Issue 605143002: [chromedriver] Accept git hashes in blink version strings from devtools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix review nits Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/devtools_http_client.h
diff --git a/chrome/test/chromedriver/chrome/devtools_http_client.h b/chrome/test/chromedriver/chrome/devtools_http_client.h
index 1e1c5ebd81a67c212979dfa7bea5cdf943978f51..3479ee0de0d7fb5548135a4bd3a66156df21bf53 100644
--- a/chrome/test/chromedriver/chrome/devtools_http_client.h
+++ b/chrome/test/chromedriver/chrome/devtools_http_client.h
@@ -10,7 +10,7 @@
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
-#include "chrome/test/chromedriver/chrome/version.h"
+#include "chrome/test/chromedriver/chrome/browser_info.h"
#include "chrome/test/chromedriver/net/sync_websocket_factory.h"
namespace base {
@@ -83,7 +83,6 @@ class DevToolsHttpClient {
const DeviceMetrics* device_metrics();
private:
- Status GetVersion(std::string* browser_version, std::string* blink_version);
Status CloseFrontends(const std::string& for_client_id);
bool FetchUrlAndLog(const std::string& url,
URLRequestContextGetter* getter,
@@ -102,9 +101,6 @@ class DevToolsHttpClient {
namespace internal {
Status ParseWebViewsInfo(const std::string& data,
WebViewsInfo* views_info);
-Status ParseVersionInfo(const std::string& data,
- std::string* browser_version,
- std::string* blink_version);
} // namespace internal
#endif // CHROME_TEST_CHROMEDRIVER_CHROME_DEVTOOLS_HTTP_CLIENT_H_
« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_impl.cc ('k') | chrome/test/chromedriver/chrome/devtools_http_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698