chrome/chrome_tests.gypi - Issue 605143002: [chromedriver] Accept git hashes in blink version strings from devtools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_tests.gypi

Issue 605143002: [chromedriver] Accept git hashes in blink version strings from devtools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix review nits Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_tests.gypi

diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi

index ae75ecd8ebab64df621912068a5fbeae1988e417..8ad5104e0863c9ff0ce052b6ccf335ead45bb0cc 100644

--- a/chrome/chrome_tests.gypi

+++ b/chrome/chrome_tests.gypi

@@ -622,6 +622,8 @@

'test/chromedriver/basic_types.h',

'test/chromedriver/capabilities.cc',

'test/chromedriver/capabilities.h',

+ 'test/chromedriver/chrome/browser_info.cc',

+ 'test/chromedriver/chrome/browser_info.h',

'test/chromedriver/chrome_launcher.cc',

'test/chromedriver/chrome_launcher.h',

'test/chromedriver/command_listener.h',

@@ -729,6 +731,7 @@

'sources': [

'test/chromedriver/capabilities_unittest.cc',

+ 'test/chromedriver/chrome/browser_info_unittest.cc',

'test/chromedriver/chrome/chrome_finder_unittest.cc',

'test/chromedriver/chrome/console_logger_unittest.cc',

'test/chromedriver/chrome/device_manager_unittest.cc',

« no previous file with comments | « no previous file | chrome/test/chromedriver/chrome/browser_info.h » ('j') | no next file with comments »