Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7696)

Unified Diff: chrome/test/chromedriver/chrome/devtools_http_client_unittest.cc

Issue 605143002: [chromedriver] Accept git hashes in blink version strings from devtools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Forgot to git add new files Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/devtools_http_client_unittest.cc
diff --git a/chrome/test/chromedriver/chrome/devtools_http_client_unittest.cc b/chrome/test/chromedriver/chrome/devtools_http_client_unittest.cc
index 651556b000565cc5213243f926808f068dfa222d..1af04b784d2f78e35034d4d5075124870764be07 100644
--- a/chrome/test/chromedriver/chrome/devtools_http_client_unittest.cc
+++ b/chrome/test/chromedriver/chrome/devtools_http_client_unittest.cc
@@ -142,39 +142,3 @@ TEST(ParseWebViewsInfo, InvalidUrl) {
"[{\"type\": \"page\", \"id\": \"1\", \"url\": 1,"
" \"webSocketDebuggerUrl\": \"ws://debugurl1\"}]");
}
-
-namespace {
-
-void AssertVersionFails(const std::string& data) {
- std::string version;
- std::string blink_version;
- Status status = internal::ParseVersionInfo(data, &version, &blink_version);
- ASSERT_TRUE(status.IsError());
- ASSERT_TRUE(version.empty());
- ASSERT_TRUE(blink_version.empty());
-}
-
-} // namespace
-
-TEST(ParseVersionInfo, InvalidJSON) {
- AssertVersionFails("[");
-}
-
-TEST(ParseVersionInfo, NonDict) {
- AssertVersionFails("[]");
-}
-
-TEST(ParseVersionInfo, NoBrowserKey) {
- AssertVersionFails("{}");
-}
-
-TEST(ParseVersionInfo, Valid) {
- std::string data = "{\"Browser\": \"1\", \"WebKit-Version\": \"2\"}";
- std::string version;
- std::string blink_version;
- Status status = internal::ParseVersionInfo(data, &version, &blink_version);
- ASSERT_TRUE(status.IsOk());
- ASSERT_EQ("1", version);
- ASSERT_EQ("2", blink_version);
-}
-

Powered by Google App Engine
This is Rietveld 408576698