[chromedriver] Accept git hashes in blink version strings from devtools

chrome/test/chromedriver/chrome/devtools_http_client.h

Index: chrome/test/chromedriver/chrome/devtools_http_client.h
diff --git a/chrome/test/chromedriver/chrome/devtools_http_client.h b/chrome/test/chromedriver/chrome/devtools_http_client.h
index 1e1c5ebd81a67c212979dfa7bea5cdf943978f51..5ba5c1e106ac3c6d859c5ce5504bc7239ac26965 100644
--- a/chrome/test/chromedriver/chrome/devtools_http_client.h
+++ b/chrome/test/chromedriver/chrome/devtools_http_client.h
@@ -83,7 +83,6 @@ class DevToolsHttpClient {
   const DeviceMetrics* device_metrics();
 
  private:
-  Status GetVersion(std::string* browser_version, std::string* blink_version);
   Status CloseFrontends(const std::string& for_client_id);
   bool FetchUrlAndLog(const std::string& url,
                       URLRequestContextGetter* getter,
@@ -100,11 +99,23 @@ class DevToolsHttpClient {
 };
 
 namespace internal {
+
 Status ParseWebViewsInfo(const std::string& data,
                          WebViewsInfo* views_info);
-Status ParseVersionInfo(const std::string& data,
-                        std::string* browser_version,
-                        std::string* blink_version);
+
+Status ParseBrowserInfo(const std::string& data,
+                        BrowserInfo* browser_info);
+
+Status ParseBrowserString(const std::string& browser,

[stgao, 2014/09/29 23:09:54]

Name |browser| is not that clear.
When I first read, I thought it was the browser name.

Maybe rename it to |browser_entry| or something?

[samuong, 2014/09/30 04:03:49]

How's |browser_string|? This is what it is called in the .cc file, and I've
changed the .h file to match.

[stgao, 2014/09/30 18:13:37]

That's good.

+                          std::string* browser_name,
+                          std::string* browser_version,
+                          int* build_no);
+
+Status ParseBlinkVersionString(const std::string& blink_version,
+                               int* blink_revision);
+
+bool IsGitHash(const std::string& revision);
+
 }  // namespace internal
 
 #endif  // CHROME_TEST_CHROMEDRIVER_CHROME_DEVTOOLS_HTTP_CLIENT_H_