Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Side by Side Diff: chrome/test/chromedriver/element_commands.cc

Issue 605143002: [chromedriver] Accept git hashes in blink version strings from devtools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix review nits Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/test/chromedriver/commands.cc ('k') | chrome/test/chromedriver/element_util.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/chromedriver/element_commands.h" 5 #include "chrome/test/chromedriver/element_commands.h"
6 6
7 #include <cmath> 7 #include <cmath>
8 #include <list> 8 #include <list>
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/callback.h" 11 #include "base/callback.h"
12 #include "base/files/file_path.h" 12 #include "base/files/file_path.h"
13 #include "base/strings/string_split.h" 13 #include "base/strings/string_split.h"
14 #include "base/strings/stringprintf.h" 14 #include "base/strings/stringprintf.h"
15 #include "base/threading/platform_thread.h" 15 #include "base/threading/platform_thread.h"
16 #include "base/time/time.h" 16 #include "base/time/time.h"
17 #include "base/values.h" 17 #include "base/values.h"
18 #include "chrome/test/chromedriver/basic_types.h" 18 #include "chrome/test/chromedriver/basic_types.h"
19 #include "chrome/test/chromedriver/chrome/browser_info.h"
19 #include "chrome/test/chromedriver/chrome/chrome.h" 20 #include "chrome/test/chromedriver/chrome/chrome.h"
20 #include "chrome/test/chromedriver/chrome/js.h" 21 #include "chrome/test/chromedriver/chrome/js.h"
21 #include "chrome/test/chromedriver/chrome/status.h" 22 #include "chrome/test/chromedriver/chrome/status.h"
22 #include "chrome/test/chromedriver/chrome/ui_events.h" 23 #include "chrome/test/chromedriver/chrome/ui_events.h"
23 #include "chrome/test/chromedriver/chrome/version.h"
24 #include "chrome/test/chromedriver/chrome/web_view.h" 24 #include "chrome/test/chromedriver/chrome/web_view.h"
25 #include "chrome/test/chromedriver/element_util.h" 25 #include "chrome/test/chromedriver/element_util.h"
26 #include "chrome/test/chromedriver/session.h" 26 #include "chrome/test/chromedriver/session.h"
27 #include "chrome/test/chromedriver/util.h" 27 #include "chrome/test/chromedriver/util.h"
28 #include "third_party/webdriver/atoms.h" 28 #include "third_party/webdriver/atoms.h"
29 29
30 const int kFlickTouchEventsPerSecond = 30; 30 const int kFlickTouchEventsPerSecond = 30;
31 31
32 namespace { 32 namespace {
33 33
(...skipping 489 matching lines...) Expand 10 before | Expand all | Expand 10 after
523 WebView* web_view, 523 WebView* web_view,
524 const std::string& element_id, 524 const std::string& element_id,
525 const base::DictionaryValue& params, 525 const base::DictionaryValue& params,
526 scoped_ptr<base::Value>* value) { 526 scoped_ptr<base::Value>* value) {
527 std::string other_element_id; 527 std::string other_element_id;
528 if (!params.GetString("other", &other_element_id)) 528 if (!params.GetString("other", &other_element_id))
529 return Status(kUnknownError, "'other' must be a string"); 529 return Status(kUnknownError, "'other' must be a string");
530 value->reset(new base::FundamentalValue(element_id == other_element_id)); 530 value->reset(new base::FundamentalValue(element_id == other_element_id));
531 return Status(kOk); 531 return Status(kOk);
532 } 532 }
OLDNEW
« no previous file with comments | « chrome/test/chromedriver/commands.cc ('k') | chrome/test/chromedriver/element_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698