src/effects/SkBlurMaskFilter.cpp - Issue 60513013: Start on GM to verify removal of 32767 limit in SkBlurMaskFilter::filterRectsToNine is okay

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkBlurMaskFilter.cpp

Issue 60513013: Start on GM to verify removal of 32767 limit in SkBlurMaskFilter::filterRectsToNine is okay (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: Ready for review Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/effects/SkBlurMaskFilter.cpp

===================================================================

--- src/effects/SkBlurMaskFilter.cpp (revision 12165)

+++ src/effects/SkBlurMaskFilter.cpp (working copy)

@@ -214,7 +214,8 @@

// TODO: report correct metrics for innerstyle, where we do not grow the

// total bounds, but we do need an inset the size of our blur-radius

- if (SkBlurMaskFilter::kInner_BlurStyle == fBlurStyle) {

+ if (SkBlurMaskFilter::kInner_BlurStyle == fBlurStyle ||

robertphillips 2013/11/07 15:39:48 Turns out the fast paths don't support outer blur

+ SkBlurMaskFilter::kOuter_BlurStyle == fBlurStyle) {

return kUnimplemented_FilterReturn;

}

« no previous file with comments | « gm/bigblurs.cpp ('k') | no next file » | no next file with comments »