cc/trees/single_thread_proxy.cc - Issue 60513007: Add SwapPromise support to LayerTreeHost and LayerTreeImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/single_thread_proxy.cc

Issue 60513007: Add SwapPromise support to LayerTreeHost and LayerTreeImpl (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: rework SwapPromise() interface to have virtual DidSwap() & DidNotSwap() interface Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/trees/single_thread_proxy.cc

diff --git a/cc/trees/single_thread_proxy.cc b/cc/trees/single_thread_proxy.cc

index 671a53b15e5e9ef89c9861ccbd5431ac6013cf97..ec11502aadd63f17e06cfab5cabd45d6935c300e 100644

--- a/cc/trees/single_thread_proxy.cc

+++ b/cc/trees/single_thread_proxy.cc

@@ -392,7 +392,12 @@ void SingleThreadProxy::CompositeImmediately(base::TimeTicks frame_begin_time) {

// the swap buffers will execute first.

BlockingTaskRunner::CapturePostTasks blocked;

- layer_tree_host_impl_->SwapBuffers(frame);

+ bool did_swap = layer_tree_host_impl_->SwapBuffers(frame);

+ if (did_swap)

+ layer_tree_host_impl_->active_tree()->FinishSwapPromise();

danakj 2013/11/13 23:22:09 Why doesn't LTHI do this directly inside SwapBuffe

Yufeng Shen (Slow to review) 2013/11/14 22:09:55 Done.

+ else

+ layer_tree_host_impl_->active_tree()->BreakSwapPromise(

+ SwapPromise::SWAP_FAILS);

}

DidSwapFrame();

}