Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 605123004: Extend JSBuiltinReducer to cover Math.abs as well. (Closed)

Created:
6 years, 2 months ago by Michael Starzinger
Modified:
6 years, 2 months ago
Reviewers:
titzer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Extend JSBuiltinReducer to cover Math.abs as well. R=titzer@chromium.org TEST=compiler-unittests/JSBuiltinReducerTest.MathAbs Committed: https://code.google.com/p/v8/source/detail?r=24255

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -0 lines) Patch
M src/compiler/graph-unittest.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/graph-unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 2 chunks +29 lines, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer-unittest.cc View 1 chunk +33 lines, -0 lines 0 comments Download
A test/mjsunit/asm/math-abs.js View 1 1 chunk +84 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Starzinger
6 years, 2 months ago (2014-09-26 11:54:39 UTC) #1
titzer
lgtm with comment https://codereview.chromium.org/605123004/diff/1/test/mjsunit/asm/math-abs.js File test/mjsunit/asm/math-abs.js (right): https://codereview.chromium.org/605123004/diff/1/test/mjsunit/asm/math-abs.js#newcode14 test/mjsunit/asm/math-abs.js:14: } How about an int32 and ...
6 years, 2 months ago (2014-09-26 13:35:14 UTC) #3
Michael Starzinger
Addressed comments. Landing. https://codereview.chromium.org/605123004/diff/1/test/mjsunit/asm/math-abs.js File test/mjsunit/asm/math-abs.js (right): https://codereview.chromium.org/605123004/diff/1/test/mjsunit/asm/math-abs.js#newcode14 test/mjsunit/asm/math-abs.js:14: } On 2014/09/26 13:35:13, titzer wrote: ...
6 years, 2 months ago (2014-09-26 13:59:39 UTC) #4
Michael Starzinger
6 years, 2 months ago (2014-09-26 14:07:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24255 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698