android_webview/common/print_messages.h - Issue 605123003: Apply automatic range checks to storage enum types across IPC in android_webview

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/common/print_messages.h

Issue 605123003: Apply automatic range checks to storage enum types across IPC in android_webview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Chanages as per coding style Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/common/print_messages.h

diff --git a/android_webview/common/print_messages.h b/android_webview/common/print_messages.h

index 76fc904e864118a9dcd42dbb4724919501f53f77..dc674fda5931d949f23a34ffed50758785f1f01c 100644

--- a/android_webview/common/print_messages.h

+++ b/android_webview/common/print_messages.h

@@ -77,8 +77,12 @@ struct PrintHostMsg_RequestPrintPreview_Params {

#define IPC_MESSAGE_START PrintMsgStart

-IPC_ENUM_TRAITS(printing::MarginType)

-IPC_ENUM_TRAITS(blink::WebPrintScalingOption)

+IPC_ENUM_TRAITS_MAX_VALUE(printing::MarginType,

+ printing::iMarginType::MARGIN_TYPE_LAST)

nasko 2014/09/29 15:18:04 You have a typo in "iMarginType".

MRV 2014/09/30 02:52:47 Done.

+IPC_ENUM_TRAITS_MAX_VALUE(

+ blink::WebPrintScalingOption,

+ blink::WebPrintScalingOption::WebPrintScalingOptionLast)

// Parameters for a render request.

IPC_STRUCT_TRAITS_BEGIN(PrintMsg_Print_Params)

« no previous file with comments | « no previous file | no next file » | no next file with comments »