Apply automatic range checks to storage enum types across IPC in android_webview

Apply automatic range checks to storage enum types across IPC in android_webview

This is part of a long-running background task to remove the remaining
uses of the unchecked IPC_ENUM_TRAITS() macro.

BUG=246708
Committed: https://crrev.com/a5f553db9b0d2305d29a6742ab1c4bc37d04c6ef
Cr-Commit-Position: refs/heads/master@{#297375}

[MRV, 2014-09-26 05:10:01]

mohan.reddy@samsung.com changed reviewers:
+ nasko@chromium.org

[MRV, 2014-09-26 05:10:02]

PTAL

[nasko, 2014-09-26 05:19:27]

https://codereview.chromium.org/605123003/diff/1/android_webview/common/print...
File android_webview/common/print_messages.h (right):

https://codereview.chromium.org/605123003/diff/1/android_webview/common/print...
android_webview/common/print_messages.h:83:
blink::WebPrintScalingOption::WebPrintScalingOptionLast)
Please format per the style guide or use clang-format.

[MRV, 2014-09-26 05:22:50]

PTAL

https://codereview.chromium.org/605123003/diff/1/android_webview/common/print...
File android_webview/common/print_messages.h (right):

https://codereview.chromium.org/605123003/diff/1/android_webview/common/print...
android_webview/common/print_messages.h:83:
blink::WebPrintScalingOption::WebPrintScalingOptionLast)
On 2014/09/26 05:19:27, nasko wrote:
> Please format per the style guide or use clang-format.

Dear Mr.nasko, thanks for your feedback.
I have made changed as per style guide, but it is crossing 80 characters, so I
prioritized in this way.
Please let me know, how to handle this issue.

[nasko, 2014-09-26 14:05:28]

On 2014/09/26 05:22:50, MRV wrote:
> PTAL
> 
>
https://codereview.chromium.org/605123003/diff/1/android_webview/common/print...
> File android_webview/common/print_messages.h (right):
> 
>
https://codereview.chromium.org/605123003/diff/1/android_webview/common/print...
> android_webview/common/print_messages.h:83:
> blink::WebPrintScalingOption::WebPrintScalingOptionLast)
> On 2014/09/26 05:19:27, nasko wrote:
> > Please format per the style guide or use clang-format.
> 
> Dear Mr.nasko, thanks for your feedback.
> I have made changed as per style guide, but it is crossing 80 characters, so I
> prioritized in this way.
> Please let me know, how to handle this issue.

You need to put both parameters on new lines with 4 space indents:

IPC_ENUM_TRAITS_MAX_VALUE(
    blink::WebPrintScalingOption,
    blink::WebPrintScalingOption::WebPrintScalingOptionLast)

[MRV, 2014-09-29 03:05:28]

On 2014/09/26 14:05:28, nasko wrote:
> On 2014/09/26 05:22:50, MRV wrote:
> > PTAL
> > 
> >
>
https://codereview.chromium.org/605123003/diff/1/android_webview/common/print...
> > File android_webview/common/print_messages.h (right):
> > 
> >
>
https://codereview.chromium.org/605123003/diff/1/android_webview/common/print...
> > android_webview/common/print_messages.h:83:
> > blink::WebPrintScalingOption::WebPrintScalingOptionLast)
> > On 2014/09/26 05:19:27, nasko wrote:
> > > Please format per the style guide or use clang-format.
> > 
> > Dear Mr.nasko, thanks for your feedback.
> > I have made changed as per style guide, but it is crossing 80 characters, so
I
> > prioritized in this way.
> > Please let me know, how to handle this issue.
> 
> You need to put both parameters on new lines with 4 space indents:
> 
> IPC_ENUM_TRAITS_MAX_VALUE(
>     blink::WebPrintScalingOption,
>     blink::WebPrintScalingOption::WebPrintScalingOptionLast)

Dear Mr. nasko, thanks for the feddback.
I have incorporated changes in patch-set 2.
PTAL.

[nasko, 2014-09-29 15:18:04]

Please compile your changes at least, so you can avoid trivial problems like
this one.

https://codereview.chromium.org/605123003/diff/20001/android_webview/common/p...
File android_webview/common/print_messages.h (right):

https://codereview.chromium.org/605123003/diff/20001/android_webview/common/p...
android_webview/common/print_messages.h:81:
printing::iMarginType::MARGIN_TYPE_LAST)
You have a typo in "iMarginType".

[MRV, 2014-09-30 02:52:47]

Dear Mr. Nasko, Thanks for feedback.
I rectified typo issue.

PTAL

https://codereview.chromium.org/605123003/diff/20001/android_webview/common/p...
File android_webview/common/print_messages.h (right):

https://codereview.chromium.org/605123003/diff/20001/android_webview/common/p...
android_webview/common/print_messages.h:81:
printing::iMarginType::MARGIN_TYPE_LAST)
On 2014/09/29 15:18:04, nasko wrote:
> You have a typo in "iMarginType".

Done.

[nasko, 2014-09-30 05:29:44]

Please send tryjobs before sending out for review in the future. You will catch
lots of simple errors and not take up your reviewer's time.
LGTM for this one.

[MRV, 2014-09-30 06:26:09]

On 2014/09/30 05:29:44, nasko wrote:
> Please send tryjobs before sending out for review in the future. You will
catch
> lots of simple errors and not take up your reviewer's time.
> LGTM for this one.

Thanks Mr. Nasko, for the review.
I'll definatly consider your suggestion.

[MRV, 2014-09-30 06:26:10]

On 2014/09/30 05:29:44, nasko wrote:
> Please send tryjobs before sending out for review in the future. You will
catch
> lots of simple errors and not take up your reviewer's time.
> LGTM for this one.

Thanks Mr. Nasko, for the review.
I'll definatly consider your suggestion.

[MRV, 2014-09-30 06:45:50]

The CQ bit was checked by mohan.reddy@samsung.com

[commit-bot: I haz the power, 2014-09-30 06:46:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/605123003/40001

[commit-bot: I haz the power, 2014-09-30 07:23:15]

Committed patchset #3 (id:40001) as 98fd8dabe45285e7ad882dbfec5afae8cf1d4831

[commit-bot: I haz the power, 2014-09-30 07:23:56]

Patchset 3 (id:??) landed as
https://crrev.com/a5f553db9b0d2305d29a6742ab1c4bc37d04c6ef
Cr-Commit-Position: refs/heads/master@{#297375}