Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 605103003: Pass request context and frame type down to Blink for redirect responses. (Closed)

Created:
6 years, 2 months ago by Mike West
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Pass request context and frame type down to Blink for redirect responses. We're currently not passing the request context or frame type correctly when performing redirects, which breaks our mixed content checking functionality for those requests. This is the Chromium side of a fix. Blink side to follow. BUG=417841 Committed: https://crrev.com/8ff9db81f82f40305f85de7e01d82c0a354d6755 Cr-Commit-Position: refs/heads/master@{#297104}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/child/web_url_loader_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Mike West
Hey Jochen, would you mind taking a look at this side of a fix for ...
6 years, 2 months ago (2014-09-26 09:43:34 UTC) #2
Mike West
Blink side pre-LGTM'd at https://codereview.chromium.org/608733002/. :)
6 years, 2 months ago (2014-09-26 13:17:21 UTC) #3
Mike West
jam@, perhaps you could review this 2-line, beta-blocker CL? :) -mike
6 years, 2 months ago (2014-09-26 17:06:47 UTC) #5
jam
lgtm
6 years, 2 months ago (2014-09-27 00:54:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/605103003/1
6 years, 2 months ago (2014-09-27 05:13:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4e47641688b501751936c157b471af6b727c648b
6 years, 2 months ago (2014-09-27 05:17:35 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-27 05:18:13 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ff9db81f82f40305f85de7e01d82c0a354d6755
Cr-Commit-Position: refs/heads/master@{#297104}

Powered by Google App Engine
This is Rietveld 408576698