Pass lsan GYP variable to swarming's test_env so that we can disable the sandbox when it's set.

Pass lsan GYP variable to swarming's test_env so that we can disable the sandbox when it's set.

This copies the logic from tools/build/scripts/slave/runtest.py in swarming.

I changed test_env.py so that it sets CHROME_DEVEL_SANDBOX to be an empty string, instead of unsetting it. The latter doesn't work as Chrome triggers checks in content/browser/browser_main_loop.cc. This is what runtest.py does.

BUG=414808, 336218
Committed: https://crrev.com/92ee4a3cbd8284c6f63cf8ca3eed384ca70b939e
Cr-Commit-Position: refs/heads/master@{#297330}

[jam, 2014-09-26 22:34:45]

Patchset #1 (id:1) has been deleted

[jam, 2014-09-27 00:44:00]

jam@chromium.org changed reviewers:
+ maruel@chromium.org

[jam, 2014-09-27 00:44:06]

Patchset #1 (id:20001) has been deleted

[M-A Ruel, 2014-09-27 01:11:08]

https://codereview.chromium.org/605063004/diff/40001/chrome/browser_tests.iso...
File chrome/browser_tests.isolate (right):

https://codereview.chromium.org/605063004/diff/40001/chrome/browser_tests.iso...
chrome/browser_tests.isolate:14: '../testing/test_env.py',
testing/xvfb calls into test_env so it's unnecessary. Maybe just ensure it's
doing the right thing w.r.t. args.

[jam, 2014-09-27 18:54:52]

https://codereview.chromium.org/605063004/diff/40001/chrome/browser_tests.iso...
File chrome/browser_tests.isolate (right):

https://codereview.chromium.org/605063004/diff/40001/chrome/browser_tests.iso...
chrome/browser_tests.isolate:14: '../testing/test_env.py',
On 2014/09/27 01:11:08, M-A Ruel wrote:
> testing/xvfb calls into test_env so it's unnecessary. Maybe just ensure it's
> doing the right thing w.r.t. args.

ah, I didn't see that. verified that it works

[M-A Ruel, 2014-09-27 19:02:14]

I think I would have preferred a --no-sandbox instead of --lsan=1 to signal it's
without sandbox but it would require mode gyp changes. lgtm to get you going so
it can be rolled in sooner.

[jam, 2014-09-27 19:10:01]

On 2014/09/27 19:02:14, M-A Ruel wrote:
> I think I would have preferred a --no-sandbox instead of --lsan=1 to signal
it's
> without sandbox but it would require mode gyp changes. lgtm to get you going
so
> it can be rolled in sooner.

That was my initial route. But then I worried that if we have more ways to
disable the sandbox in the future it would be awkward or not possible (given
isolate's limited expressions) to express this in isolates. I'm flexible either
way though, I can switch it to --no-sandbox if you prefer that.

[jam, 2014-09-29 15:54:20]

Patchset #3 (id:80001) has been deleted

[jam, 2014-09-29 16:33:05]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2014-09-29 16:34:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/605063004/60001

[commit-bot: I haz the power, 2014-09-29 16:41:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-29 16:41:58]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jam, 2014-09-29 17:13:23]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2014-09-29 17:14:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/605063004/60001

[jam, 2014-09-29 17:15:36]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2014-09-29 17:15:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/605063004/100001

[commit-bot: I haz the power, 2014-09-29 17:47:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-29 17:47:23]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[jam, 2014-09-29 20:10:54]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2014-09-29 20:12:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/605063004/100001

[commit-bot: I haz the power, 2014-09-29 21:37:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-29 21:37:04]

Try jobs failed on following builders:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2014-09-29 21:40:26]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2014-09-29 21:41:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/605063004/100001

[commit-bot: I haz the power, 2014-09-29 23:07:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-29 23:07:03]

Try jobs failed on following builders:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2014-09-29 23:30:02]

jam@chromium.org changed reviewers:
+ bbudge@chromium.org

[jam, 2014-09-29 23:30:14]

+bbudge for ppapi

[jam, 2014-09-29 23:30:18]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2014-09-29 23:31:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/605063004/120001

[bbudge, 2014-09-29 23:38:22]

NaCl lgtm

[commit-bot: I haz the power, 2014-09-30 01:22:18]

Committed patchset #4 (id:120001) as b5541b743c22e7539a9a13e1803f978a7d1d535f

[commit-bot: I haz the power, 2014-09-30 01:23:14]

Patchset 4 (id:??) landed as
https://crrev.com/92ee4a3cbd8284c6f63cf8ca3eed384ca70b939e
Cr-Commit-Position: refs/heads/master@{#297330}