Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 605063003: Clean up forward declarations in Source/core/fetch and /loader (Closed)

Created:
6 years, 2 months ago by zhaoze.zhou
Modified:
6 years, 2 months ago
Reviewers:
Nate Chapin, rwlbuis
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Clean up forward declarations in Source/core/fetch and /loader These forward references are not needed anymore. After this patch, Source/core/fetch and Source/core/loader has no unneeded forward references anymore. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182797

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M Source/core/fetch/CSSStyleSheetResource.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/fetch/CrossOriginAccessControl.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/fetch/FetchContext.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/fetch/MemoryCache.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/fetch/RawResource.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/fetch/Resource.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/fetch/ResourceFetcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/fetch/ResourceLoader.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/fetch/ResourceLoaderHost.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/fetch/TextResource.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/fetch/XSLStyleSheetResource.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/loader/FrameLoaderClient.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhaoze.zhou
6 years, 2 months ago (2014-09-26 21:05:13 UTC) #3
Nate Chapin
If it compiles, LGTM
6 years, 2 months ago (2014-09-26 21:54:05 UTC) #4
zhaoze.zhou
On 2014/09/26 21:54:05, Nate Chapin wrote: > If it compiles, LGTM complies success now.
6 years, 2 months ago (2014-09-26 22:29:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/605063003/40001
6 years, 2 months ago (2014-09-26 22:29:29 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 22:34:07 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 182797

Powered by Google App Engine
This is Rietveld 408576698