Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 605013003: Don't clear the string stub at gc time in KeyedLoadIC. (Closed)

Created:
6 years, 2 months ago by mvstanton
Modified:
6 years, 2 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Don't clear the string stub at gc time in KeyedLoadIC. Clearing this stub doesn't actually make sense, as it neither leaks memory, nor prevents finding a new optimum stable state. As long as strings receivers are observed, this is the best stub. The moment we see a non-string receiver we'll go polymorphic or generic depending on the case. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24360

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M src/ic/ic.cc View 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
mvstanton
Hi Yang, Here is the change I was jawing about. :) Thanks, --Michael
6 years, 2 months ago (2014-09-26 12:15:45 UTC) #2
Yang
On 2014/09/26 12:15:45, mvstanton wrote: > Hi Yang, > Here is the change I was ...
6 years, 2 months ago (2014-09-26 12:16:23 UTC) #3
mvstanton
6 years, 2 months ago (2014-10-01 11:09:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24360 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698