Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Side by Side Diff: content/renderer/media/android/webmediaplayer_android.h

Issue 605013002: Refactor MediaSourceDelegate destruction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mp4_stream_parser_hack
Patch Set: comments addressed Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_ 5 #ifndef CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_
6 #define CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_ 6 #define CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 437 matching lines...) Expand 10 before | Expand all | Expand 10 after
448 #if defined(VIDEO_HOLE) 448 #if defined(VIDEO_HOLE)
449 // A rectangle represents the geometry of video frame, when computed last 449 // A rectangle represents the geometry of video frame, when computed last
450 // time. 450 // time.
451 gfx::RectF last_computed_rect_; 451 gfx::RectF last_computed_rect_;
452 452
453 // Whether to use the video overlay for all embedded video. 453 // Whether to use the video overlay for all embedded video.
454 // True only for testing. 454 // True only for testing.
455 bool force_use_overlay_embedded_video_; 455 bool force_use_overlay_embedded_video_;
456 #endif // defined(VIDEO_HOLE) 456 #endif // defined(VIDEO_HOLE)
457 457
458 scoped_ptr<MediaSourceDelegate,
459 MediaSourceDelegate::Destroyer> media_source_delegate_;
460
461 MediaPlayerHostMsg_Initialize_Type player_type_; 458 MediaPlayerHostMsg_Initialize_Type player_type_;
462 459
463 // Whether the browser is currently connected to a remote media player. 460 // Whether the browser is currently connected to a remote media player.
464 bool is_remote_; 461 bool is_remote_;
465 462
466 scoped_refptr<media::MediaLog> media_log_; 463 scoped_refptr<media::MediaLog> media_log_;
467 464
468 scoped_ptr<MediaInfoLoader> info_loader_; 465 scoped_ptr<MediaInfoLoader> info_loader_;
469 466
470 // The currently selected key system. Empty string means that no key system 467 // The currently selected key system. Empty string means that no key system
(...skipping 25 matching lines...) Expand all
496 // Whether the resource is local. 493 // Whether the resource is local.
497 bool is_local_resource_; 494 bool is_local_resource_;
498 495
499 // base::TickClock used by |interpolator_|. 496 // base::TickClock used by |interpolator_|.
500 base::DefaultTickClock default_tick_clock_; 497 base::DefaultTickClock default_tick_clock_;
501 498
502 // Tracks the most recent media time update and provides interpolated values 499 // Tracks the most recent media time update and provides interpolated values
503 // as playback progresses. 500 // as playback progresses.
504 media::TimeDeltaInterpolator interpolator_; 501 media::TimeDeltaInterpolator interpolator_;
505 502
503 scoped_ptr<MediaSourceDelegate> media_source_delegate_;
504
506 // NOTE: Weak pointers must be invalidated before all other member variables. 505 // NOTE: Weak pointers must be invalidated before all other member variables.
507 base::WeakPtrFactory<WebMediaPlayerAndroid> weak_factory_; 506 base::WeakPtrFactory<WebMediaPlayerAndroid> weak_factory_;
508 507
509 DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerAndroid); 508 DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerAndroid);
510 }; 509 };
511 510
512 } // namespace content 511 } // namespace content
513 512
514 #endif // CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_ 513 #endif // CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_
OLDNEW
« no previous file with comments | « content/renderer/media/android/media_source_delegate.cc ('k') | content/renderer/media/android/webmediaplayer_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698