Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1389)

Issue 604983002: Disable two hanging video capture tests on Windows. (Closed)

Created:
6 years, 2 months ago by Jamie Madill
Modified:
6 years, 2 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, miu+watch_chromium.org, Ken Russell (switch to Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable two hanging video capture tests on Windows. Seems to happen in Debug mode. Turn these off until we can find a fix. BUG=417824, 416594 Committed: https://crrev.com/6a4c65109c324475d0ef73c829968f9251e832f6 Cr-Commit-Position: refs/heads/master@{#297275}

Patch Set 1 #

Patch Set 2 : Fix "_DEBUG" #

Total comments: 1

Patch Set 3 : Updated style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M media/video/capture/video_capture_device_unittest.cc View 1 2 2 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Jamie Madill
PTAL
6 years, 2 months ago (2014-09-25 23:06:19 UTC) #2
Jamie Madill
Review ping @tommi.. or if you can't review, do you know who I should add?
6 years, 2 months ago (2014-09-29 20:03:07 UTC) #3
miu
Review comments, but you'll need someone else for OWNERS approval. https://codereview.chromium.org/604983002/diff/20001/media/video/capture/video_capture_device_unittest.cc File media/video/capture/video_capture_device_unittest.cc (right): https://codereview.chromium.org/604983002/diff/20001/media/video/capture/video_capture_device_unittest.cc#newcode61 ...
6 years, 2 months ago (2014-09-29 20:13:19 UTC) #5
Ken Russell (switch to Gerrit)
+scherkus,vrk,dalecurtis for OWNERS reviews after miu@'s feedback is addressed.
6 years, 2 months ago (2014-09-29 20:39:23 UTC) #7
scherkus (not reviewing)
lgtm
6 years, 2 months ago (2014-09-29 20:49:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604983002/40001
6 years, 2 months ago (2014-09-29 21:16:35 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001) as aae3023d4a23078f4fa6f793b241bccf2f014fef
6 years, 2 months ago (2014-09-29 21:45:07 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 21:46:05 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6a4c65109c324475d0ef73c829968f9251e832f6
Cr-Commit-Position: refs/heads/master@{#297275}

Powered by Google App Engine
This is Rietveld 408576698