Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 60493003: Assertion hit / crash in EventSource::abortConnectionAttempt() (Closed)

Created:
7 years, 1 month ago by Inactive
Modified:
7 years, 1 month ago
CC:
blink-reviews, lgombos
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Assertion hit / crash in EventSource::abortConnectionAttempt() Fix a possible assertion hit in EventSource::abortConnectionAttempt() when attempting a cross-origin request towards a non-HTTP URL, an early verification of the protocol scheme will cause didFailAccessControlCheck to be called synchronously before the loader has even finished being created. This special case was not handled properly, since we tried to cancel a non-existing loader, which resulted in a crash. In addition to checking whether a request is in flight before trying to cancel it, this change also schedules the initial creation of the loader to happen asynchronously when when an EventSource is constructed, so that a script can register for the error event before it is dispatched (as a result of passing a non-HTTP URL to the constructor). This patch is based on WebKit r149098 by Per-Erik Brodin <per-erik.brodin@ericsson.com>;. BUG=315178 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161464

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -10 lines) Patch
A LayoutTests/http/tests/eventsource/eventsource-cors-non-http.html View 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/eventsource/eventsource-cors-non-http-expected.txt View 1 chunk +17 lines, -0 lines 0 comments Download
M Source/core/page/EventSource.h View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/page/EventSource.cpp View 6 chunks +20 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
7 years, 1 month ago (2013-11-05 19:22:54 UTC) #1
Ken Russell (switch to Gerrit)
The patch looks reasonable to me but I'm really not the best person to review ...
7 years, 1 month ago (2013-11-05 19:30:58 UTC) #2
abarth-chromium
lgtm
7 years, 1 month ago (2013-11-06 18:02:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/60493003/1
7 years, 1 month ago (2013-11-06 18:02:25 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-06 19:20:29 UTC) #5
Message was sent while issue was closed.
Change committed as 161464

Powered by Google App Engine
This is Rietveld 408576698