content: Move IOSurface backed GpuMemoryBuffer allocation to GPU process.

content: Move IOSurface backed GpuMemoryBuffer allocation to GPU process.

BUG=325045
Committed: https://crrev.com/dfa74e6b9bf23e0c4635982d9754e7f3a2b8f250
Cr-Commit-Position: refs/heads/master@{#296816}

[reveman, 2014-09-25 19:20:20]

reveman@chromium.org changed reviewers:
+ piman@chromium.org

[reveman, 2014-09-25 19:20:20]

Note that this is missing proper destruction support just like ozone native
buffers. I'll make sure that's fixed at the same time we fix ozone or I'll
rebase this to do the right thing if ozone fix lands before.

FYI, allocating IO surfaces on the GPU process side will allow us to use mach
ports to transfer ownership to the renderer instead of making them global. It
will basically work the same way ownership is transferred in the SurfaceTexture
case on Android but use mach port IPC instead of Java IPC.

[piman, 2014-09-25 20:46:28]

lgtm

https://codereview.chromium.org/604903005/diff/1/content/common/gpu/gpu_memor...
File content/common/gpu/gpu_memory_buffer_factory_io_surface.cc (right):

https://codereview.chromium.org/604903005/diff/1/content/common/gpu/gpu_memor...
content/common/gpu/gpu_memory_buffer_factory_io_surface.cc:16:
CFDictionaryAddValue(
nit: do we need an include for this (IWYU) ?

https://codereview.chromium.org/604903005/diff/1/content/common/gpu/gpu_memor...
content/common/gpu/gpu_memory_buffer_factory_io_surface.cc:41:
base::ScopedCFTypeRef<CFMutableDictionaryRef> properties;
nit: and this?

[reveman, 2014-09-25 21:13:23]

https://codereview.chromium.org/604903005/diff/1/content/common/gpu/gpu_memor...
File content/common/gpu/gpu_memory_buffer_factory_io_surface.cc (right):

https://codereview.chromium.org/604903005/diff/1/content/common/gpu/gpu_memor...
content/common/gpu/gpu_memory_buffer_factory_io_surface.cc:16:
CFDictionaryAddValue(
On 2014/09/25 20:46:27, piman (Very slow to review) wrote:
> nit: do we need an include for this (IWYU) ?

Done.

https://codereview.chromium.org/604903005/diff/1/content/common/gpu/gpu_memor...
content/common/gpu/gpu_memory_buffer_factory_io_surface.cc:41:
base::ScopedCFTypeRef<CFMutableDictionaryRef> properties;
On 2014/09/25 20:46:27, piman (Very slow to review) wrote:
> nit: and this?

Done.

[reveman, 2014-09-25 21:13:30]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2014-09-25 21:15:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/604903005/20001

[commit-bot: I haz the power, 2014-09-25 23:06:15]

Committed patchset #2 (id:20001) as 32d9db50d57a237307d52bd2a4a42ee44c542c53

[commit-bot: I haz the power, 2014-09-25 23:07:09]

Patchset 2 (id:??) landed as
https://crrev.com/dfa74e6b9bf23e0c4635982d9754e7f3a2b8f250
Cr-Commit-Position: refs/heads/master@{#296816}