Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 604873004: Fix SkTableColorFilter deserialization validation. (Closed)

Created:
6 years, 2 months ago by Stephen White
Modified:
6 years, 2 months ago
Reviewers:
hcm, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Increase buffer size in test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M src/effects/SkTableColorFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SerializationTest.cpp View 1 4 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604873004/1
6 years, 2 months ago (2014-09-25 21:57:49 UTC) #2
Stephen White
reed@: I'm landing this one TBR since it's preventing a lot of filters from rendering ...
6 years, 2 months ago (2014-09-25 22:00:40 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on tryserver.skia (http://108.170.220.120:10117/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/812)
6 years, 2 months ago (2014-09-25 22:15:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604873004/20001
6 years, 2 months ago (2014-09-25 22:43:52 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 91c395af69cf10cd13062f143811a7a9a3ce03c7
6 years, 2 months ago (2014-09-25 22:51:39 UTC) #8
mtklein
6 years, 2 months ago (2014-09-25 23:01:06 UTC) #10
Message was sent while issue was closed.
Seems like something we'll want on the M39 branch, no?

I know we nominally branched at b5fae93d72c, though the details of that actually
existing or not and when it might exist are unclear to me.  Heather will know
best.

Powered by Google App Engine
This is Rietveld 408576698