Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: src/assembler_ia32.h

Issue 604873003: Handle add, adc, etc., mfence, div, idiv, mul in the assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceInstX8632.cpp ('k') | src/assembler_ia32.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/assembler_ia32.h
diff --git a/src/assembler_ia32.h b/src/assembler_ia32.h
index 2dc0c12e95b71c71e1e83755344003669323a432..83c0b667e0387e93453296aebebd6cf8ad4b16e8 100644
--- a/src/assembler_ia32.h
+++ b/src/assembler_ia32.h
@@ -571,40 +571,43 @@ public:
void testl(GPRRegister reg1, GPRRegister reg2);
void testl(GPRRegister reg, const Immediate &imm);
- void andl(GPRRegister dst, const Immediate &imm);
- void andl(GPRRegister dst, GPRRegister src);
- void andl(GPRRegister dst, const Address &address);
+ void And(Type Ty, GPRRegister dst, GPRRegister src);
+ void And(Type Ty, GPRRegister dst, const Address &address);
+ void And(Type Ty, GPRRegister dst, const Immediate &imm);
- void orl(GPRRegister dst, const Immediate &imm);
- void orl(GPRRegister dst, GPRRegister src);
- void orl(GPRRegister dst, const Address &address);
+ void Or(Type Ty, GPRRegister dst, GPRRegister src);
+ void Or(Type Ty, GPRRegister dst, const Address &address);
+ void Or(Type Ty, GPRRegister dst, const Immediate &imm);
- void xorl(GPRRegister dst, const Immediate &imm);
- void xorl(GPRRegister dst, GPRRegister src);
- void xorl(GPRRegister dst, const Address &address);
+ void Xor(Type Ty, GPRRegister dst, GPRRegister src);
+ void Xor(Type Ty, GPRRegister dst, const Address &address);
+ void Xor(Type Ty, GPRRegister dst, const Immediate &imm);
- void addl(GPRRegister dst, GPRRegister src);
- void addl(GPRRegister reg, const Immediate &imm);
- void addl(GPRRegister reg, const Address &address);
+ void add(Type Ty, GPRRegister dst, GPRRegister src);
+ void add(Type Ty, GPRRegister reg, const Address &address);
+ void add(Type Ty, GPRRegister reg, const Immediate &imm);
- void addl(const Address &address, GPRRegister reg);
- void addl(const Address &address, const Immediate &imm);
+ void adc(Type Ty, GPRRegister dst, GPRRegister src);
+ void adc(Type Ty, GPRRegister dst, const Address &address);
+ void adc(Type Ty, GPRRegister reg, const Immediate &imm);
- void adcl(GPRRegister dst, GPRRegister src);
- void adcl(GPRRegister reg, const Immediate &imm);
- void adcl(GPRRegister dst, const Address &address);
- void adcl(const Address &dst, GPRRegister src);
+ void sub(Type Ty, GPRRegister dst, GPRRegister src);
+ void sub(Type Ty, GPRRegister reg, const Address &address);
+ void sub(Type Ty, GPRRegister reg, const Immediate &imm);
- void subl(GPRRegister dst, GPRRegister src);
- void subl(GPRRegister reg, const Immediate &imm);
- void subl(GPRRegister reg, const Address &address);
- void subl(const Address &address, GPRRegister reg);
+ void sbb(Type Ty, GPRRegister dst, GPRRegister src);
+ void sbb(Type Ty, GPRRegister reg, const Address &address);
+ void sbb(Type Ty, GPRRegister reg, const Immediate &imm);
void cbw();
void cwd();
void cdq();
- void idivl(GPRRegister reg);
+ void div(Type Ty, GPRRegister reg);
+ void div(Type Ty, const Address &address);
+
+ void idiv(Type Ty, GPRRegister reg);
+ void idiv(Type Ty, const Address &address);
void imull(GPRRegister dst, GPRRegister src);
void imull(GPRRegister reg, const Immediate &imm);
@@ -613,13 +616,8 @@ public:
void imull(GPRRegister reg);
void imull(const Address &address);
- void mull(GPRRegister reg);
- void mull(const Address &address);
-
- void sbbl(GPRRegister dst, GPRRegister src);
- void sbbl(GPRRegister reg, const Immediate &imm);
- void sbbl(GPRRegister reg, const Address &address);
- void sbbl(const Address &address, GPRRegister reg);
+ void mul(Type Ty, GPRRegister reg);
+ void mul(Type Ty, const Address &address);
void incl(GPRRegister reg);
void incl(const Address &address);
@@ -670,6 +668,8 @@ public:
void jmp(Label *label, bool near = kFarJump);
void jmp(const ConstantRelocatable *label);
+ void mfence();
+
void lock();
void cmpxchg(Type Ty, const Address &address, GPRRegister reg);
void cmpxchg8b(const Address &address);
« no previous file with comments | « src/IceInstX8632.cpp ('k') | src/assembler_ia32.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698