Handle add, adc, etc., mfence, div, idiv, mul in the assembler.

tests_lit/assembler/x86/immediate_encodings.ll

Index: tests_lit/assembler/x86/immediate_encodings.ll
diff --git a/tests_lit/assembler/x86/immediate_encodings.ll b/tests_lit/assembler/x86/immediate_encodings.ll
new file mode 100644
index 0000000000000000000000000000000000000000..3b0f389eed92977854128ae0c49e6b04cd33f50e
--- /dev/null
+++ b/tests_lit/assembler/x86/immediate_encodings.ll
@@ -0,0 +1,114 @@
+; Tests various aspects of x86 immediate encoding. Some encodings are shorter.
+; For example, the encoding is shorter for 8-bit immediates or when using EAX.
+; This assumes that EAX is chosen as the first free register in O2 mode.
+
+; RUN: %p2i -i %s --args -O2 --verbose none \
+; RUN:   | llvm-mc -triple=i686-none-nacl -x86-asm-syntax=intel -filetype=obj \
+; RUN:   | llvm-objdump -d --symbolize -x86-asm-syntax=intel - | FileCheck %s
+; RUN: %p2i -i %s --args --verbose none | FileCheck --check-prefix=ERRORS %s
+; RUN: %p2i -i %s --insts | %szdiff %s | FileCheck --check-prefix=DUMP %s
+
+define internal i32 @testXor8Imm8(i32 %arg) {
+entry:
+  %arg_i8 = trunc i32 %arg to i8
+  %result_i8 = xor i8 %arg_i8, 127
+  %result = zext i8 %result_i8 to i32
+  ret i32 %result
+}
+; CHECK-LABEL: testXor8Imm8
+; CHECK: 34 7f   xor al, 127
+
+define internal i32 @testXor8Imm8Neg(i32 %arg) {
+entry:
+  %arg_i8 = trunc i32 %arg to i8
+  %result_i8 = xor i8 %arg_i8, -128
+  %result = zext i8 %result_i8 to i32
+  ret i32 %result
+}
+; CHECK-LABEL: testXor8Imm8Neg
+; CHECK: 34 80   xor al, -128
+
+define internal i32 @testXor8Imm8NotEAX(i32 %arg, i32 %arg2, i32 %arg3) {
+entry:
+  %arg_i8 = trunc i32 %arg to i8
+  %arg2_i8 = trunc i32 %arg2 to i8
+  %arg3_i8 = trunc i32 %arg3 to i8
+  %x1 = xor i8 %arg_i8, 127
+  %x2 = xor i8 %arg2_i8, 127
+  %x3 = xor i8 %arg3_i8, 127
+  %x4 = add i8 %x1, %x2
+  %x5 = add i8 %x4, %x3
+  %result = zext i8 %x5 to i32
+  ret i32 %result
+}
+; CHECK-LABEL: testXor8Imm8NotEAX
+; CHECK: 80 f1 7f xor {{[^a]}}l, 127

[Jim Stichnoth, 2014/09/26 02:31:36]

(This applies to testXor32Imm32NotEAX as well.)

You listed the entire 3-byte encoding, which would seem to fix a particular
register?  I would say either list one of the registers explicitly, or use
another regex for the encoding that captures the 3 (?) possibilities.

[jvoung (off chromium), 2014/09/26 16:25:50]

Ah good point =)

Added regex of 1-3, for c, d, and b.

+
+define internal i32 @testXor32Imm8(i32 %arg) {
+entry:
+  %result = xor i32 %arg, 127
+  ret i32 %result
+}
+; CHECK-LABEL: testXor32Imm8
+; CHECK: 83 f0 7f   xor eax, 127
+
+define internal i32 @testXor32Imm8Neg(i32 %arg) {
+entry:
+  %result = xor i32 %arg, -128
+  ret i32 %result
+}
+; CHECK-LABEL: testXor32Imm8Neg
+; CHECK: 83 f0 80   xor eax, -128
+
+define internal i32 @testXor32Imm32Eax(i32 %arg) {
+entry:
+  %result = xor i32 %arg, 16777216
+  ret i32 %result
+}
+; CHECK-LABEL: testXor32Imm32Eax
+; CHECK: 35 00 00 00 01   xor eax, 16777216
+
+define internal i32 @testXor32Imm32NegEax(i32 %arg) {
+entry:
+  %result = xor i32 %arg, -256
+  ret i32 %result
+}
+; CHECK-LABEL: testXor32Imm32NegEax
+; CHECK: 35 00 ff ff ff   xor eax, 4294967040
+
+define internal i32 @testXor32Imm32NotEAX(i32 %arg, i32 %arg2, i32 %arg3) {
+entry:
+  %x = xor i32 %arg, 32767
+  %x2 = xor i32 %arg2, 32767
+  %x3 = xor i32 %arg3, 32767
+  %add1 = add i32 %x, %x2
+  %add2 = add i32 %add1, %x3
+  ret i32 %add2
+}
+; CHECK-LABEL: testXor32Imm32NotEAX
+; CHECK: 81 f1 ff 7f 00 00   xor e{{[^a]}}x, 32767
+
+; Should be similar for add, sub, etc., so sample a few.
+
+define internal i32 @testAdd8Imm8(i32 %arg) {
+entry:
+  %arg_i8 = trunc i32 %arg to i8
+  %result_i8 = add i8 %arg_i8, 126
+  %result = zext i8 %result_i8 to i32
+  ret i32 %result
+}
+; CHECK-LABEL: testAdd8Imm8
+; CHECK: 04 7e   add al, 126
+
+define internal i32 @testSub8Imm8(i32 %arg) {
+entry:
+  %arg_i8 = trunc i32 %arg to i8
+  %result_i8 = sub i8 %arg_i8, 125
+  %result = zext i8 %result_i8 to i32
+  ret i32 %result
+}
+; CHECK-LABEL: testSub8Imm8
+; CHECK: 2c 7d  sub al, 125
+
+; ERRORS-NOT: ICE translation error
+; DUMP-NOT: SZ