Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: src/assembler_ia32.h

Issue 604873003: Handle add, adc, etc., mfence, div, idiv, mul in the assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/assembler_ia32.h
diff --git a/src/assembler_ia32.h b/src/assembler_ia32.h
index b5c9a16097649bce33c2e9aab68026c802631109..b3252ea6b81b321d045ff2cc02b9420d055472e3 100644
--- a/src/assembler_ia32.h
+++ b/src/assembler_ia32.h
@@ -572,40 +572,43 @@ public:
void testl(GPRRegister reg1, GPRRegister reg2);
void testl(GPRRegister reg, const Immediate &imm);
- void andl(GPRRegister dst, const Immediate &imm);
- void andl(GPRRegister dst, GPRRegister src);
- void andl(GPRRegister dst, const Address &address);
+ void And(Type Ty, GPRRegister dst, GPRRegister src);
+ void And(Type Ty, GPRRegister dst, const Address &address);
+ void And(Type Ty, GPRRegister dst, const Immediate &imm);
- void orl(GPRRegister dst, const Immediate &imm);
- void orl(GPRRegister dst, GPRRegister src);
- void orl(GPRRegister dst, const Address &address);
+ void Or(Type Ty, GPRRegister dst, GPRRegister src);
+ void Or(Type Ty, GPRRegister dst, const Address &address);
+ void Or(Type Ty, GPRRegister dst, const Immediate &imm);
- void xorl(GPRRegister dst, const Immediate &imm);
- void xorl(GPRRegister dst, GPRRegister src);
- void xorl(GPRRegister dst, const Address &address);
+ void Xor(Type Ty, GPRRegister dst, GPRRegister src);
+ void Xor(Type Ty, GPRRegister dst, const Address &address);
+ void Xor(Type Ty, GPRRegister dst, const Immediate &imm);
- void addl(GPRRegister dst, GPRRegister src);
- void addl(GPRRegister reg, const Immediate &imm);
- void addl(GPRRegister reg, const Address &address);
+ void add(Type Ty, GPRRegister dst, GPRRegister src);
+ void add(Type Ty, GPRRegister reg, const Address &address);
+ void add(Type Ty, GPRRegister reg, const Immediate &imm);
- void addl(const Address &address, GPRRegister reg);
- void addl(const Address &address, const Immediate &imm);
+ void adc(Type Ty, GPRRegister dst, GPRRegister src);
+ void adc(Type Ty, GPRRegister dst, const Address &address);
+ void adc(Type Ty, GPRRegister reg, const Immediate &imm);
- void adcl(GPRRegister dst, GPRRegister src);
- void adcl(GPRRegister reg, const Immediate &imm);
- void adcl(GPRRegister dst, const Address &address);
- void adcl(const Address &dst, GPRRegister src);
+ void sub(Type Ty, GPRRegister dst, GPRRegister src);
+ void sub(Type Ty, GPRRegister reg, const Address &address);
+ void sub(Type Ty, GPRRegister reg, const Immediate &imm);
- void subl(GPRRegister dst, GPRRegister src);
- void subl(GPRRegister reg, const Immediate &imm);
- void subl(GPRRegister reg, const Address &address);
- void subl(const Address &address, GPRRegister reg);
+ void sbb(Type Ty, GPRRegister dst, GPRRegister src);
+ void sbb(Type Ty, GPRRegister reg, const Address &address);
+ void sbb(Type Ty, GPRRegister reg, const Immediate &imm);
void cbw();
void cwd();
void cdq();
- void idivl(GPRRegister reg);
+ void div(Type Ty, GPRRegister reg);
+ void div(Type Ty, const Address &address);
+
+ void idiv(Type Ty, GPRRegister reg);
+ void idiv(Type Ty, const Address &address);
void imull(GPRRegister dst, GPRRegister src);
void imull(GPRRegister reg, const Immediate &imm);
@@ -614,13 +617,8 @@ public:
void imull(GPRRegister reg);
void imull(const Address &address);
- void mull(GPRRegister reg);
- void mull(const Address &address);
-
- void sbbl(GPRRegister dst, GPRRegister src);
- void sbbl(GPRRegister reg, const Immediate &imm);
- void sbbl(GPRRegister reg, const Address &address);
- void sbbl(const Address &address, GPRRegister reg);
+ void mul(Type Ty, GPRRegister reg);
+ void mul(Type Ty, const Address &address);
void incl(GPRRegister reg);
void incl(const Address &address);
@@ -671,6 +669,8 @@ public:
void jmp(Label *label, bool near = kFarJump);
void jmp(const ConstantRelocatable *label);
+ void mfence();
+
void lock();
void cmpxchg(Type Ty, const Address &address, GPRRegister reg);
void cmpxchg8b(const Address &address);

Powered by Google App Engine
This is Rietveld 408576698