Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 604853002: Add new git port to merge_to_branch script. (Closed)

Created:
6 years, 2 months ago by Michael Achenbach
Modified:
6 years, 2 months ago
Reviewers:
tandrii(chromium)
CC:
v8-dev, Jakob Kummerow
Project:
v8
Visibility:
Public.

Description

Add new git port to merge_to_branch script. BUG=chromium:410721 LOG=n TEST=script_test.py R=tandrii@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24239

Patch Set 1 : Initial with simple copy of old merge_to_branch tests #

Total comments: 1

Patch Set 2 : Changed new test. #

Total comments: 1

Patch Set 3 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -3 lines) Patch
M tools/push-to-trunk/common_includes.py View 1 2 4 chunks +44 lines, -1 line 0 comments Download
M tools/push-to-trunk/test_scripts.py View 1 2 2 chunks +133 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Achenbach
PTAL. The test is 1:1 c/p to ease review. After the git switch, the first ...
6 years, 2 months ago (2014-09-25 15:41:39 UTC) #2
tandrii(chromium)
lgtm https://codereview.chromium.org/604853002/diff/20001/tools/push-to-trunk/common_includes.py File tools/push-to-trunk/common_includes.py (right): https://codereview.chromium.org/604853002/diff/20001/tools/push-to-trunk/common_includes.py#newcode780 tools/push-to-trunk/common_includes.py:780: parser.add_argument("--vc-port", why "port" and not "interface"? Is it ...
6 years, 2 months ago (2014-09-25 15:53:53 UTC) #3
Michael Achenbach
Done
6 years, 2 months ago (2014-09-26 07:22:15 UTC) #4
Michael Achenbach
6 years, 2 months ago (2014-09-26 07:40:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 24239 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698