Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Issue 604843003: Check that extensions::HidDeviceManager is used from the FILE thread. (Closed)

Created:
6 years, 2 months ago by Reilly Grant (use Gerrit)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Check that extensions::HidDeviceManager is used from the FILE thread. Commit 7fb8b9950 attempted to enable an unused thread check in extensions::HidDeviceManager but this was not correct because while this class is normally used from the FILE thread this is not where it is created (issue 417939). This change adopts the pattern used in extensions::ApiResourceManager where the BrowserContextKeyedAPI implements its own thread assertions. BUG= Committed: https://crrev.com/ea245886e3af507367cae1d9d766755f4384d588 Cr-Commit-Position: refs/heads/master@{#297013}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M extensions/browser/api/hid/hid_device_manager.h View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/browser/api/hid/hid_device_manager.cc View 5 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Reilly Grant (use Gerrit)
6 years, 2 months ago (2014-09-26 17:10:39 UTC) #2
Ken Rockot(use gerrit already)
lgtm
6 years, 2 months ago (2014-09-26 18:48:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604843003/1
6 years, 2 months ago (2014-09-26 19:52:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 9abe5191b522cba4823039cb629e1a6a59815d98
6 years, 2 months ago (2014-09-26 19:56:39 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 19:57:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea245886e3af507367cae1d9d766755f4384d588
Cr-Commit-Position: refs/heads/master@{#297013}

Powered by Google App Engine
This is Rietveld 408576698