Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 604833006: [DOCS] Add supported OSs and platforms to the SDK download page. (Closed)

Created:
6 years, 2 months ago by jpmedley
Modified:
6 years, 2 months ago
Reviewers:
mkearney1, smain, JF
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[DOCS] Add supported OSs and platforms to the SDK download page. BUG=none R= TEST=none NOTRY=true (documentation only change) Committed: https://crrev.com/c3be53f0316e7c75c2b0e9a084ae163e00d0d9bc Cr-Commit-Position: refs/heads/master@{#297511}

Patch Set 1 #

Patch Set 2 : Remove file accidentally added. #

Total comments: 1

Patch Set 3 : Fix a typo #

Patch Set 4 : Remove file accidentally added by Make. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M native_client_sdk/doc_generated/sdk/download.html View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M native_client_sdk/doc_generated/sitemap.html View 1 chunk +2 lines, -1 line 0 comments Download
M native_client_sdk/src/doc/sdk/download.rst View 1 2 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jpmedley
6 years, 2 months ago (2014-09-29 21:00:47 UTC) #2
JF
lgtm after typo fix. https://codereview.chromium.org/604833006/diff/20001/native_client_sdk/src/doc/sdk/download.rst File native_client_sdk/src/doc/sdk/download.rst (right): https://codereview.chromium.org/604833006/diff/20001/native_client_sdk/src/doc/sdk/download.rst#newcode81 native_client_sdk/src/doc/sdk/download.rst:81: Native Client supports several operating ...
6 years, 2 months ago (2014-09-30 21:05:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/604833006/60001
6 years, 2 months ago (2014-09-30 21:46:12 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 51f18ecad6618125492c99a0ec1b29d20e626e68
6 years, 2 months ago (2014-09-30 21:47:33 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 21:49:08 UTC) #7
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c3be53f0316e7c75c2b0e9a084ae163e00d0d9bc
Cr-Commit-Position: refs/heads/master@{#297511}

Powered by Google App Engine
This is Rietveld 408576698